Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add NoPluginManagement, NoAccessManagement config options #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RamblingCookieMonster
Copy link
Contributor

Add NoPluginManagement and NoAccessManagement configuration options per #79

Description

Add NoPluginManagement and NoAccessManagement configuration options per #79

Boiled down: Limit the risk of potential unauthorized management of plugins and RBAC by configuring plugins and access ahead of time, and adding these configurations to prevent changes to plugins / RBAC via PoshBot.

Related Issue

#79

Motivation and Context

Reduce risk. See issue and description

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@RamblingCookieMonster
Copy link
Contributor Author

Starting to work on this, if it makes sense. At the moment I've simply added the config pieces - next step is actually locking down based on someone using these in their config

@devblackops
Copy link
Member

Sounds good @RamblingCookieMonster. Thanks!

@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement in progress pinned Prevent closing if stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants