Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade container-linux-config-transpiler to v0.5.0 #14

Merged
merged 2 commits into from
Nov 16, 2017

Conversation

dhensen
Copy link
Contributor

@dhensen dhensen commented Oct 24, 2017

I needed this because I was using the terraform provider together with a CoreOS 1548.2.0 which has Ignition 2.1.0 spec. My machine kept failing on boot, turned out that directories were not provisioned because the provider used an outdated ct version. I hope I did a good job... If not, let me know how I can improve this PR!

@dghubble
Copy link
Member

dghubble commented Nov 1, 2017

New Container Linux images should accept Ignition v2.0.0 configs. I'd like to retain support and test coverage for v2.0.0 configs to continue to support a range of Container Linux versions, whereas v2.1.0 can only be used with new Container Linux images. At least until v2.1.0 is broadly available.

We may want to make convert_as = "some-version" a configurable option so users may opt-in to newer versions. Or Container Linux configs add a version field directly.

cc @dgonyeo who works on ct

@cgonyeo
Copy link

cgonyeo commented Nov 1, 2017

FWIW v2.1.0 is supported in CL stable

@dghubble
Copy link
Member

dghubble commented Nov 1, 2017

Crawford points out v2.1.0 support was added in 1465.0.0. If this tool starts producing v2.1.0 configs, we have that as a minimum required version.

@dghubble
Copy link
Member

dghubble commented Nov 9, 2017

This was discussed and sounds like we're ok cutting releases of this tool that note a minimum version. This can be incorporated into v0.3.0.

rel poseidon/matchbox#670

@dghubble dghubble self-requested a review November 9, 2017 01:02
@dghubble dghubble merged commit f41ec2e into poseidon:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants