Script to access data from the GSA#69
Merged
TCLamnidis merged 9 commits intoposeidon-framework:add_2025_Liu_ShanDongfrom Apr 29, 2025
Merged
Script to access data from the GSA#69TCLamnidis merged 9 commits intoposeidon-framework:add_2025_Liu_ShanDongfrom
TCLamnidis merged 9 commits intoposeidon-framework:add_2025_Liu_ShanDongfrom
Conversation
Member
|
Hi @Kavlahkaff, great that you're on this. Let us know when this is ready for review, happy to take a look. |
Contributor
Author
|
Hi @stschiff, the script itself is ready for review. I had discussed with @TCLamnidis to add the .janno for 2025_Liu_ShanDong to this PR as well, which is why its still in draft. |
Contributor
Author
|
@delphis-bot create recipe |
Member
|
Thank you @Kavlahkaff! I still want to make some more tweaks to the script to bring it up to speed with changes I recently made to the equivalent script for the ENA. I will now merge this into a temporary branch and separate the script from the recipe, so the recipe can be updated after the changes in |
TCLamnidis
merged commit 8465174
into
poseidon-framework:add_2025_Liu_ShanDong
2 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add a script to download data from the GSA and write it to a .ssf file.
Linked to #67
Closes #68
PR Checklist
update. (Add to
Linked to #XXXabove.)