Add package: 2021_Orlando_NeoBa#54
Open
PierreJust wants to merge 3 commits intoposeidon-framework:mainfrom
Open
Add package: 2021_Orlando_NeoBa#54PierreJust wants to merge 3 commits intoposeidon-framework:mainfrom
PierreJust wants to merge 3 commits intoposeidon-framework:mainfrom
Conversation
Member
|
@PierreJust This PR requires an issue to be opened, to provide the additional required information (doi, link to publication). |
Member
|
Hi @PierreJust ! Apologies for my delayed response. The SSF is currently missing the required I cannot process the recipe until this information is provided, as there is no information on how to fill the eager input file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #56
PR Checklist
new packageorpackage update).Add/update package: {package_name}.update. (Add to
Linked to #XXXabove.)If adding or updating a package:
.ssf) for the requestedpackage.
.ssffile(s) matches the package name (i.e.packages/2023_my_package/2023_my_package.ssf)..ssffile MUST contain a new line at the end of the file.A check for this exists in the CI. This check should pass before
you continue with this list.
@delphis-bot create recipeto this pull request to awakenPoseidon's trusty helper. (This should be repeated whenever changes are
made to the SSF file contents).
Delphis-bot will then add a number of files to the PR. Check that they are all
there:
packages/{package_name}/{package_name}.tsvwas added to the PR.packages/{package_name}/{package_name}.tsv_patch.shwas addedto the PR from template.
packages/{package_name}/script_versions.txtwas added to thePR.
packages/{package_name}/{package_name}.configwas added to thePR from template.
Human validation
Package SSF file (
*.ssf)poseidon_IDs,udg, andlibrary_builtare filledand correct.
noteswhere necessary to explain any specialcases/judgement calls made for data entries.
Package TSV file (
*.tsv)UDG,Strandednesscolumns are correct for eachlibrary.
R1_target_fileandR2_target_filecolumns point tothe correct FastQ files for the library (i.e. consistent with SSF file).
Package config file (
*.config)The template config file includes a few
TODOstatements, and information aboutthem. Please ensure that you:
have added them within the
paramssection at the end of the packageconfig file.