This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Fix colorize stream target #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes updated spec helper capture_lines wich calls uncolorize by default. Updates Webmock to latest version c673f393
|
Thanks! I'll give it a quick review and merge it ASAP |
|
Good catch! While it didn't cause any real issue because only |
|
Your welcome. I was just browsing through some crystal code to get to know the language a bit better and happend to notice a possible error. If crystal-lang/crystal#3925 gets merged, there might be some changes how colorize works. But there's a spec now ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colorize's
surroundmethod usesSTDOUTby default, if command's output is a differentIO, then ANSI escape codes would still be printed toSTDOUTand contents to@output.Includes updated spec helper
capture_lineswich callsuncolorizeby default.Updates Webmock to latest version c673f393 because specs would not run with old version.