Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Myanmar and its info (currencies, etc) #37

Open
tanagnostis opened this issue Dec 8, 2021 · 3 comments
Open

Please add Myanmar and its info (currencies, etc) #37

tanagnostis opened this issue Dec 8, 2021 · 3 comments

Comments

@tanagnostis
Copy link

tanagnostis commented Dec 8, 2021

Hi!

Is it possible to add Myanmar and its info?

Thanks

@voidus
Copy link
Contributor

voidus commented Feb 4, 2022

There's already an entry about Burma. As far as I can see, the library doesn't yet have an approach to handle situations like that.

@jeanbaptisteb
Copy link

jeanbaptisteb commented Feb 9, 2022

There's already an entry about Burma. As far as I can see, the library doesn't yet have an approach to handle situations like that.

I'm running into the same issue. I installed the package today from pip (never used or installed it before), and "Burma" as an alternative to "Myanmar" is not available either.

from countryinfo import CountryInfo
CountryInfo("Burma").info()

throws the error KeyError: 'burma'
I uninstalled the package and reinstalled it, the problem is still here. I'm under windows 10, Python 3.7, 64bits, the installed package version is countryinfo-0.1.2.

Maybe "Burma" is only available in the development version?

@voidus
Copy link
Contributor

voidus commented Feb 9, 2022

Okay I had a look at the code and burma.json isn't loaded because it doesn't have a name entry. Since I'm just a passer-by, I can't speak on the intentions. The code that ignores those files is there since the first commit as far as I can tell.

FWIW, these files don't have a name set:

['antarctica.json',
 'ashmore_and_cartier_island.json',
 'burma.json',
 'clipperton_island.json',
 'europa_island.json',
 'gaza_strip.json',
 'glorioso_islands.json',
 'holy_see_vatican_city.json',
 'hungary.json',
 'ireland_northern.json',
 'jan_mayen.json',
 'jarvis_island.json',
 'johnston_atoll.json',
 'juan_de_nova_island.json',
 'midway_islands.json',
 'netherlands_antilles.json',
 'west_bank.json',
 'virgin_islands.json']

Jeremys11 pushed a commit to Jeremys11/countryinfo that referenced this issue Oct 27, 2023
Addressing lack of Myanmar info in issue porimol#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants