Group rules enhancements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add subswitches to rule command: name & group - Support searching by rule name - Match also by plain-text group names - Print group rule name - Alert if a group ID is missing in Okta
Golang doesn't seem to support lookahead or lookbehind so times are hard...
... and change unicode arrow to ->
- Move regexpes to global variables, so they are only compiled once - Remove color codes in printed results (might mess up copy pasting) - Change rule name matching to be case insensitive to make it work like rule group matching - For rule command align destination groups in output to make output look nicer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
120% Go noob so please let me know if something is weird.
Also wish Go supported lookahead/lookbehind for Regex 😢