-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proprietary audio codec support for the new NW.js version #2062
Comments
Locally I tried it with v0.52.0 and I've tested some basic functionalities and haven't found anything broken. Since our current version works there's no hurry to do this but I think that there are some benefits (recent memory usage optimizations). If you could tag this as a Feature would be great. Could you upload new NWjs SDK too? Anyone can do this but it would be easier if anyone deletes their cache folders. From there it's all about changing version defined in one of the source files. |
Hello,
PT successfully builds but do not launch (no clear log is output). I tested 0.44.5, 0.52.0 and 0.52.2 and none of them worked. Thanks for reading Edit : from what I understand, I have to include support at compile time for various proprietary codecs in NWJS. Still, it is unclear to me what steps I have to setup for a complete compile script. |
What've done is a bit different. I manually downloaded NWjs SDK and put it into my cache folder since I wanted minimal change in actual code. Also version that worked for me was |
I removed those two lines without providing new downloadUrl.
The build fallback to download by itself, seem nwjs-sdk-v0.44.5 works perfectly.
|
Thanks it works. I have problems accessing https://get.popcorntime.app/repo/nw/ is this domain down or is it just blocked by my ISP?
|
@memarko domain is down manifestUrl: 'http://popcorn-ru.tk/version.json', |
Is this reliable or secure? |
@isaamos it's safe |
FFmpeg can be added manually to SDK or SDK itself can be built with included codec (it's an option if you build NWjs manually). So this means we can download NWjs from https://nwjs.io/downloads/ and add prebuilt FFmpeg codec from https://github.com/iteufel/nwjs-ffmpeg-prebuilt. I've tested it locally with NWjs 54.1 and prebuilt FFmpeg for 54. Can someone else test this and report if there are any issues/benefits with newer version of Chromium? |
For me build with external ffmpeg not work - many films without sound |
i commit current build script to for build full nwjs need about 60gb space and it work about week on oracle free vm |
How did you download it on mac? Its not opening for me |
How did you test? |
Can you provide me with a download link to the working version? (I am on mac) |
Hey, I did it a different way. I bumped the NWJS version to 0.55 in gulpfile.js then removed the 2 lines where it takes downloads from. I built it using instructions in readme, but did not start. Then I downloaded Ivan's audio fixed and put it in builds then ran it. Ran just fine on Monterey. 0.55 Nwjs downloaded into my cache |
https://youtu.be/3IZid6lBMJM I have a fix, you can watch from the link. |
@Kief5555 you write this 5 times |
some videos do, wont they have sound if they have the codecs? |
@Kief5555 need rebuild full nwjs with enable codecs patch |
@ivan1986 Do you have the link to downloaded these codecs? |
what link? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
it seems the build artifacts are expired: https://github.com/popcorn-official/popcorn-desktop/actions/runs/5496485657 |
Is your feature request related to a problem? Please describe.
Not related to a problem but the project is using outdated version.
Describe the idea you'd like
App loads NWjs from https://get.popcorntime.app/repo/nw/. First step would be to upload newer version to allow easier testing than manually tricking app on local build.
Describe alternatives you've considered
We can stay on existing version?
Additional context
NWjs link https://nwjs.io/
The text was updated successfully, but these errors were encountered: