Skip to content

Commit

Permalink
coresight: ultrasoc-smb: Fix uninitialized before use buf_hw_base
Browse files Browse the repository at this point in the history
In smb_reset_buffer, the sdb->buf_hw_base variable is uninitialized
before use, which initializes it in smb_init_data_buffer. And the SMB
regiester are set in smb_config_inport.
So move the call after smb_config_inport.

Fixes: 06f5c29 ("drivers/coresight: Add UltraSoc System Memory Buffer driver")
Signed-off-by: Junhao He <[email protected]>
Reviewed-by: James Clark <[email protected]>
Signed-off-by: Suzuki K Poulose <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
Junhao He authored and Suzuki K Poulose committed Nov 16, 2023
1 parent 830a7f5 commit 862c135
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hwtracing/coresight/ultrasoc-smb.c
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,6 @@ static int smb_init_data_buffer(struct platform_device *pdev,
static void smb_init_hw(struct smb_drv_data *drvdata)
{
smb_disable_hw(drvdata);
smb_reset_buffer(drvdata);

writel(SMB_LB_CFG_LO_DEFAULT, drvdata->base + SMB_LB_CFG_LO_REG);
writel(SMB_LB_CFG_HI_DEFAULT, drvdata->base + SMB_LB_CFG_HI_REG);
Expand Down Expand Up @@ -587,6 +586,7 @@ static int smb_probe(struct platform_device *pdev)
if (ret)
return ret;

smb_reset_buffer(drvdata);
platform_set_drvdata(pdev, drvdata);
spin_lock_init(&drvdata->spinlock);
drvdata->pid = -1;
Expand Down

0 comments on commit 862c135

Please sign in to comment.