Skip to content

Commit

Permalink
video: backlight: Drop maximum brightness override for brightness zero
Browse files Browse the repository at this point in the history
The note in c2adda2 ("video: backlight: Add of_find_backlight helper
in backlight.c") says that gpio-backlight uses brightness as power state.
This has been fixed since in ec665b7 ("backlight: gpio-backlight:
Correct initial power state handling") and other backlight drivers do not
require this workaround. Drop the workaround.

This fixes the case where e.g. pwm-backlight can perfectly well be set to
brightness 0 on boot in DT, which without this patch leads to the display
brightness to be max instead of off.

Fixes: c2adda2 ("video: backlight: Add of_find_backlight helper in backlight.c")
Cc: <[email protected]> # 5.4+
Cc: <[email protected]> # 4.19.x: ec665b7: backlight: gpio-backlight: Correct initial power state handling
Signed-off-by: Marek Vasut <[email protected]>
Acked-by: Noralf Trønnes <[email protected]>
Reviewed-by: Daniel Thompson <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
Marek Vasut authored and Lee Jones committed Sep 22, 2021
1 parent 6880fa6 commit 33a5471
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/video/backlight/backlight.c
Original file line number Diff line number Diff line change
Expand Up @@ -688,12 +688,6 @@ static struct backlight_device *of_find_backlight(struct device *dev)
of_node_put(np);
if (!bd)
return ERR_PTR(-EPROBE_DEFER);
/*
* Note: gpio_backlight uses brightness as
* power state during probe
*/
if (!bd->props.brightness)
bd->props.brightness = bd->props.max_brightness;
}
}

Expand Down

0 comments on commit 33a5471

Please sign in to comment.