-
Notifications
You must be signed in to change notification settings - Fork 52
Alt tab with workspace & output support #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ok this should be working now with pop-os/cosmic-launcher#225 and the master branch of cosmic-comp. alt+tab reflects focus changes properly now and i don't believe there are regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing unexpected behavior with this and pop-os/cosmic-launcher#225. See the following:
2024-12-06.18-25-10.mp4
Steps to recreate the issue:
- Open two windows on a workspace. Alt-tab switches between them as expected.
- Switch to a new workspace and open a third window. Alt-tab switches back to the first workspace.
- Now alt-tab is stuck on a single window.
- I'm assuming it's supposed to switch us back to the previously activated window on the other workspace, but it should at least switch to the other window on the active workspace instead of doing nothing.
Just double checking, which version of cosmic-comp was running when you tried this? When I try to copy what is done in your video with 7829e76 it works as expected. |
Ah, I was still on e3b41c5 from release, sorry. After adding master to this machine, it is working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alt-tab is now working as expected on single display/workspace, multiple workspaces, multiple displays, and multiple workspaces/displays. It is currently limited to the last 8 windows. Tested in COSMIC on 24.04 and 22.04.
Launcher regression testing passed (22.04 GNOME):
Launcher
- All windows on all workspaces appear on launch
- Choosing an app on another workspace moves workspaces and focus to that app
- Launching an application works
- Typing text and then removing it will re-show those windows
- Search works for applications and windows
- Search works for GNOME settings panels
- Search for "Extensions". There should be only one entry.
- The overlay hint correctly highlights the selected window
- Open windows are sorted above applications (e.g. "firefox")
- t: executes a command in a terminal
- : executes a command in sh
- = calculates an equation
- Search results are as expected:
cal
returns Calendar and Calculator before Colorpops
returns Popsicle firstshop
returns the Pop!_Shop first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
} | ||
|
||
false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like in the future it would be nicer if the plugin.ron files would have an "AlwaysShowIn"-key similar to desktop files, so that other desktops could more easily extend this, if they support the necessary protocols. (Why do the plugins not use desktop-files in the first place?)
Anyway, this is good enough for now.
No description provided.