Skip to content

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Dec 5, 2024

No description provided.

@wash2 wash2 marked this pull request as ready for review December 5, 2024 17:42
@wash2
Copy link
Contributor Author

wash2 commented Dec 5, 2024

Ok this should be working now with pop-os/cosmic-launcher#225 and the master branch of cosmic-comp. alt+tab reflects focus changes properly now and i don't believe there are regressions.

@wash2 wash2 requested review from jacobgkau and mmstick December 5, 2024 17:49
@jacobgkau jacobgkau requested review from a team and removed request for jacobgkau December 6, 2024 18:00
@jacobgkau jacobgkau self-assigned this Dec 6, 2024
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing unexpected behavior with this and pop-os/cosmic-launcher#225. See the following:

2024-12-06.18-25-10.mp4

Steps to recreate the issue:

  1. Open two windows on a workspace. Alt-tab switches between them as expected.
  2. Switch to a new workspace and open a third window. Alt-tab switches back to the first workspace.
  3. Now alt-tab is stuck on a single window.
    • I'm assuming it's supposed to switch us back to the previously activated window on the other workspace, but it should at least switch to the other window on the active workspace instead of doing nothing.

@wash2
Copy link
Contributor Author

wash2 commented Dec 6, 2024

I'm still seeing unexpected behavior with this and pop-os/cosmic-launcher#225. See the following:
2024-12-06.18-25-10.mp4

Steps to recreate the issue:

1. Open two windows on a workspace. Alt-tab switches between them as expected.

2. Switch to a new workspace and open a third window. Alt-tab switches back to the first workspace.

3. Now alt-tab is stuck on a single window.
   
   * I'm assuming it's supposed to switch us back to the previously activated window on the other workspace, but it should at least switch to the other window on the active workspace instead of doing nothing.

Just double checking, which version of cosmic-comp was running when you tried this? When I try to copy what is done in your video with 7829e76 it works as expected.

@jacobgkau
Copy link
Member

Ah, I was still on e3b41c5 from release, sorry. After adding master to this machine, it is working as expected.

@jacobgkau jacobgkau dismissed their stale review December 6, 2024 19:25

Outdated

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt-tab is now working as expected on single display/workspace, multiple workspaces, multiple displays, and multiple workspaces/displays. It is currently limited to the last 8 windows. Tested in COSMIC on 24.04 and 22.04.

Launcher regression testing passed (22.04 GNOME):

Launcher

  • All windows on all workspaces appear on launch
  • Choosing an app on another workspace moves workspaces and focus to that app
  • Launching an application works
  • Typing text and then removing it will re-show those windows
  • Search works for applications and windows
  • Search works for GNOME settings panels
  • Search for "Extensions". There should be only one entry.
  • The overlay hint correctly highlights the selected window
  • Open windows are sorted above applications (e.g. "firefox")
  • t: executes a command in a terminal
  • : executes a command in sh
  • = calculates an equation
  • Search results are as expected:
    • cal returns Calendar and Calculator before Color
    • pops returns Popsicle first
    • shop returns the Pop!_Shop first

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

}

false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like in the future it would be nicer if the plugin.ron files would have an "AlwaysShowIn"-key similar to desktop files, so that other desktops could more easily extend this, if they support the necessary protocols. (Why do the plugins not use desktop-files in the first place?)

Anyway, this is good enough for now.

@wash2 wash2 merged commit c37c2a3 into master Dec 9, 2024
8 checks passed
@wash2 wash2 deleted the alt-tab-with-workspace-support-1 branch December 9, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants