Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make xdg-desktop-portal-cosmic path non fixed to libexec #79

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Keloran
Copy link

@Keloran Keloran commented Oct 31, 2024

arch and other dists dont use libexec

@Keloran Keloran mentioned this pull request Oct 31, 2024
@Drakulix
Copy link
Member

This now instead just hard codes two paths. Please make this build-time configurable (e.g. via an env-variable), like we do in other projects instead.

Justfile Outdated Show resolved Hide resolved
@Keloran
Copy link
Author

Keloran commented Oct 31, 2024

Moved to env setting hopefully did "COSMIC_DESKTOP_PORTAL" as the env setting, hopefully is an acceptable name

@Keloran Keloran requested a review from jackpot51 October 31, 2024 14:49
@ryanabx
Copy link
Contributor

ryanabx commented Nov 1, 2024

This is semi-related to this PR as well pop-os/launcher#242 , which is also setting an environment variable to use something different than the default (in launcher the current default is lib)

@Conan-Kudo
Copy link

Yeah, I mentioned in there we should default to libexec there since nearly all distributions use it, and those that don't can override it accordingly.

@Keloran
Copy link
Author

Keloran commented Nov 9, 2024

This now instead just hard codes two paths. Please make this build-time configurable (e.g. via an env-variable), like we do in other projects instead.

is this change more what you were after ?

Justfile Outdated Show resolved Hide resolved
Co-authored-by: Neal Gompa (ニール・ゴンパ) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants