Skip to content

Bump compio; remove unused dependency#1577

Merged
jacobgkau merged 1 commit intopop-os:masterfrom
joshuamegnauth54:bump-compio-remove-unused
Jan 29, 2026
Merged

Bump compio; remove unused dependency#1577
jacobgkau merged 1 commit intopop-os:masterfrom
joshuamegnauth54:bump-compio-remove-unused

Conversation

@joshuamegnauth54
Copy link
Copy Markdown
Contributor

While looking into #1563, I found out that compio just released (literally five hours ago 😆) 0.18 which includes your mtime patch. So, Files can just use the stable version again.

I removed the io-uring dependency which Files isn't using. The io-uring crate is a tokio crate but compio is entirely different. compio also has an io_uring feature which we're already using.

As for #1563, it turns out the musl supports statx and there's already a PR to add it: rust-lang/libc#4478

So hopefully that is fixed and merged soon.

@jacobgkau jacobgkau requested review from a team January 29, 2026 20:27
jackpot51
jackpot51 previously approved these changes Jan 29, 2026
@jacobgkau
Copy link
Copy Markdown
Member

#1535 was just merged and caused a conflict with this PR.

@joshuamegnauth54
Copy link
Copy Markdown
Contributor Author

Alright. I rebased it.

Copy link
Copy Markdown
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression testing passed:

Checklist

Basic navigation

  • Middle-click opens directory in a new tab (not focused).
  • Open two scrollable tabs. Scroll one tab, then switch to the other tab; it should not have scrolled.
  • Hover over the top item in the folder, then scroll down until it's out of view (while still hovered). On scrolling back up (with the mouse in a different position), the item should not have the hover highlight.
  • Right-click an item in the sidebar. No visual change should occur with the rest of the items.
    • Not a regression.
  • Remove an item from the sidebar, then re-pin it.

File operations

  • Right-click -> Create a new folder, then enter it.
  • Right-click in the empty folder -> Create a new file.
  • Navigate to the parent folder, create another new file, then drag it into the created folder.
  • Files can be renamed.
  • Files can be opened with non-default apps & browsing store for new apps works.
  • Normal right-click shows Move to trash option.
  • Shift right-click, and right-click followed by Shift, both show Permanently delete option.

Advanced navigation & view settings

  • Image and video thumbnails generate & display in local folders.
  • Gallery preview shows with Spacebar.
  • Details pane shows with Ctrl+Spacebar.
  • Zoom in/out and reset to default zoom work.
  • Ctrl+1 and Ctrl+2 switch between list and icon view.
  • Ctrl+H shows/hides hidden files.
  • Directories can be sorted at top or inline.
  • Settings -> Theme works.
  • Settings -> Type to Search affects behavior as designed.
  • Single-click to open setting takes effect.
  • Sorting options work.
  • Cutting, copying, and pasting files works.
  • F5 reloads current directory.
  • Left sidebar can be collapsed and expanded.

External filesystems

  • Add a network drive (e.g. SFTP) and navigate into it.
  • Plug in a USB drive; able to mount, browse, and eject.

Integrations

  • Desktop icons display as expected
  • Drag-and-drop into Firefox works

@jacobgkau jacobgkau merged commit 339e4c1 into pop-os:master Jan 29, 2026
11 checks passed
@joshuamegnauth54 joshuamegnauth54 deleted the bump-compio-remove-unused branch January 30, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants