Skip to content

feat: tab dnd#490

Merged
jackpot51 merged 1 commit intomasterfrom
feat/tab-dnd
Feb 9, 2026
Merged

feat: tab dnd#490
jackpot51 merged 1 commit intomasterfrom
feat/tab-dnd

Conversation

@wash2
Copy link
Copy Markdown
Contributor

@wash2 wash2 commented Jan 16, 2026

No description provided.

@wash2 wash2 requested review from a team and jackpot51 January 16, 2026 19:34
jackpot51
jackpot51 previously approved these changes Jan 16, 2026
@wash2 wash2 force-pushed the feat/tab-dnd branch 3 times, most recently from 3284371 to f754b31 Compare January 26, 2026 16:07
@jacobgkau jacobgkau self-assigned this Jan 26, 2026
@wash2 wash2 force-pushed the feat/tab-dnd branch 3 times, most recently from 3a68954 to ea40fac Compare January 29, 2026 01:07
Copy link
Copy Markdown
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a weird behavior remaining that's not present in pop-os/cosmic-files#1535. I think it's either because COSMIC Edit doesn't fill the entire tab space by default like COSMIC Files does, or because COSMIC Edit has the modified indicator dot that sometimes shows up in tabs.

If I press Shift while hovering over a tab, the tab gets slightly larger until I either press Shift over a different tab or click somewhere in the app. See the result of pressing Shift over one tab and then the other below:

2026-01-29.12-58-08.mp4

@jackpot51
Copy link
Copy Markdown
Member

@wash2 can you update this PR?

@jacobgkau
Copy link
Copy Markdown
Member

The issue I described in #490 (review) is still present in this one.

@wash2
Copy link
Copy Markdown
Contributor Author

wash2 commented Feb 3, 2026

The issue I described in #490 (review) is still present in this one.

Ya, I'm not sure that I have a great fix for that issue at this time.

@jacobgkau
Copy link
Copy Markdown
Member

I will open an issue for the modifiers causing tabs to resize and proceed with regression testing the rest of this, since the issue is minor compared to the functionality being added (and is not a regression).

Copy link
Copy Markdown
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab interaction has no regressions with the new dragging functionality.

Regression testing passed:

Basic operations

  • Type three lines of text (no trailing newline).
  • Copy the last two lines.
  • Paste at the end of the third line (file should now have four lines).
  • Ctrl-Z to undo the paste.
  • Press Enter to add a trailing newline.
  • Paste again (file should now have five lines).
  • Ctrl-Z to undo the paste.
  • Ctrl-Shift-Z to redo the paste.
  • Save the file.
  • Ctrl-F and search for something that has a match.
  • Press Esc twice to exit the Find dialog.
  • Press Ctrl-X to cut the selected search result.
  • Paste the cut text on a new line (file should now have six lines).
  • Re-save the file.
  • Narrow the window until the lines start wrapping (make a line longer if necessary to observe line wrapping).
  • Turn word wrapping off.
  • Scroll right to the end of the document, then left to the beginning again.
    • Active line highlight stops after visible part scrolls; not a regression.
  • Click and drag to select some text past the horizontal edge of the window.
  • Close the file, open COSMIC Edit again, and open the file via the recents list.
    • Doesn't show up; not a regression: #460
  • Close the file again, open COSMIC Edit again, and open the file via the Open dialog.
  • Turn word wrapping back on.

Settings

  • Open View -> Settings.
  • All Appearance settings work.
  • Vim bindings work.

Projects & Git Management

  • Clone the cosmic-edit Git repo and open its directory as a project.
  • Edit -> Find in project... works.
  • Make a change in a file.
  • File -> Git management shows the change and staging it works.
  • Make another change while Git management's open; it updates to show the new change.
  • Un-staging a change works.

@jackpot51 jackpot51 merged commit ef63c2f into master Feb 9, 2026
10 checks passed
@jackpot51 jackpot51 deleted the feat/tab-dnd branch February 9, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants