Recalculate tiling layout on change of display configuration #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drakulix
approved these changes
Nov 12, 2024
Previously, changing the resolution, scale, or orientation of a display left tiling layouts that don't fill the screen and/or extend off of the screen area, until an action like opening a window makes it recalculate window positions. Now this is done immediately when the output configuration changes. Perhaps we should consider if we want a different animation for things like rotating a screen, but the current behavior isn't too bad. For floating layouts, `refresh` already remaps windows that are out of bounds for the output, so this doesn't change that. Perhaps decreasing the resolution (or moving to a lower resolution output) should try to reduce the window size. But the current behavior generally seems okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, changing the resolution, scale, or orientation of a display left tiling layouts that don't fill the screen and/or extend off of the screen area, until an action like opening a window makes it recalculate window positions.
Now this is done immediately when the output configuration changes.
Perhaps we should consider if we want a different animation for things like rotating a screen, but the current behavior isn't too bad.
For floating layouts,
refreshalready remaps windows that are out of bounds for the output, so this doesn't change that. Perhaps decreasing the resolution (or moving to a lower resolution output) should try to reduce the window size. But the current behavior generally seems okay.