Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smithay, with xwayland shell changes #478

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented May 13, 2024

I see there's another breaking Smithay change (noticed this in #477).

For some reason Xwayland clients don't seem to show up now...

@ids1024
Copy link
Member Author

ids1024 commented May 14, 2024

Looks like the client does create the surface, xwayland shell surface sets the serial, and attach a buffer.

Maybe something relies on wl_surface being Some before it is?

@ids1024
Copy link
Member Author

ids1024 commented May 21, 2024

Updated for more Smithay changes. The Cow stuff is a bit annoying to deal with.

Xwayland still isn't working here.

@Drakulix
Copy link
Member

XwmHandler::map_window_notify isn't called anymore, working on it.

@Drakulix
Copy link
Member

Should be fixed by Smithay/smithay#1436

@ids1024 ids1024 marked this pull request as ready for review May 21, 2024 17:22
@Drakulix Drakulix merged commit 4f076e0 into master May 21, 2024
@Tipcat-98
Copy link

Tipcat-98 commented May 21, 2024

On cosmic-comp-4f076e0 I still get cosmic-comp crashes with certain xwayland apps and empty windows on others (only the title bar shows).

With error messages like:
May 21 21:23:44 tipcat cosmic-comp[6140]: Failed to handle X11 event

I'm on Nvidia

If you'd like to test:
Path of Building: Empty Window
Discord in X11 mode: cosmic-comp crash

@gabriele2000
Copy link

gabriele2000 commented May 22, 2024

Agreed, Steam, for example, doesn't show up anymore.
Running on a laptop, hybrid Intel+Nvidia GPU setup

@ids1024 ids1024 deleted the smithay-update branch June 19, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants