Fix raw string regex patterns #743
Open
+250
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'r' prefix to regex patterns in: - pony/orm/dbproviders/oracle.py - pony/orm/dbapiprovider.py - pony/thirdparty/decorator.py - pony/converting.py Fixes ponyorm#693
ewlsh
force-pushed
the
fix-raw-string-regex
branch
from
df6e4d0 to
d0c6581
Compare
ewlsh
commented
Mar 6, 2025
| except: | ||
| if value == '': return None | ||
| raise ValidationError(err_msg or 'Incorrect data') | ||
| from __future__ import absolute_import, print_function |
There was a problem hiding this comment.
Hiding whitespace while reviewing this is very helpful, github treats file encoding changes as whitespace.
ewlsh
commented
Mar 6, 2025
|
|
||
| month_lists = [ | ||
| "jan feb mar apr may jun jul aug sep oct nov dec".split(), | ||
| u"янв фев мар апр май июн июл авг сен окт ноя дек".split(), # Russian |
There was a problem hiding this comment.
This should be reviewed by someone knowledgeable in the Russian equivalents, this is AI-generated.
cc @kozlovsky
There was a problem hiding this comment.
I've run iconv locally with the same commands the agent used and verified this is the output but I am not familiar with Russian so if there is an encoding issue it would be non-obvious to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix raw string regex patterns and update
converting.pyencodingThis PR addresses #693 which is generating a fair amount of logging spam when I'm using Pony.
Context
Python 3.12 changed the way escape sequences in strings work with regular expressions. From the Python 3.12 changelog:
Changes
Added 'r' prefix to regex patterns in:
pony/orm/dbproviders/oracle.py:json_item_repony/orm/dbapiprovider.py:version_repony/thirdparty/decorator.py:DEFpony/converting.py:date_re_list,time_re,datetime_re_listNote:
email_reandrfc2822_email_reinconverting.pyalready had the 'r' prefix.Additionally,
converting.pywas converted from cp1251 to UTF-8 encoding using:iconv -f cp1251 -t utf-8 pony/converting.py > pony/converting.py.utf8 mv pony/converting.py.utf8 pony/converting.pyThis encoding change aligns with a similar change made in #669.
Why
Using raw strings for regex patterns is a Python best practice because:
This PR was generated with https://www.all-hands.dev/ (an open source agent) but I have reviewed the code changes prior to submitting, noted potential areas for review, and adjusted this description to include additional context.