Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code related to updating columns #534

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Improve code related to updating columns #534

merged 4 commits into from
Jan 24, 2025

Conversation

gartens
Copy link
Contributor

@gartens gartens commented Jan 17, 2025

Summary

This PR fixes various issues related to updating columns.

Changes

  • It is no longer possible to set the nullable flag for fields that are part of a primary key
  • Update collectionType when changing the column type
  • Do not update the default value when the old and new default value are both NULL
  • Return after the first update statement that fails. Previously it reported the status of the last statement, which might be success even with previous statements failing.

vogti
vogti approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @gartens, for this PR!

@vogti vogti merged commit 7922965 into master Jan 24, 2025
32 checks passed
@vogti vogti deleted the update-column branch January 24, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogti vogti vogti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gartens @vogti