New validation on wildcard was added to AbstractJdbcSource.java, #479
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces a check during the parsing of settings to determine whether the value associated with the "tables" key is a wildcard character "*". If it is, an exception will be thrown.
Fixes: #477
Changes
Implemented a validation mechanism within the settings parser that checks for the presence of a wildcard character "*" as the value for the "tables" key. Prior to this change, the parser did not restrict the use of wildcard characters, which could lead to ambiguous or unintended behavior.
Features
Wildcard ‘*’ Validation
Bug Fixes
Adding Data Source Tables containing wildcards '*' breaks schema
Tests
1.use '*' to select tables
2.web UI prompts 'unable to add
3.The exception output appears in the console section of the IDE.
Further Contribution
If this solution is deemed viable, it will be necessary to implement the same validation check across the remaining five implementations. Ensuring this consistency will maintain the protection against using a wildcard character '*' as a table name across the entire codebase, which is critical for the comprehensive resolution of issue #477.
