Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres - Interface #421

Open
wants to merge 57 commits into
base: master
Choose a base branch
from
Open

Postgres - Interface #421

wants to merge 57 commits into from

Conversation

flurfis
Copy link

@flurfis flurfis commented Nov 2, 2022

Summary

Implemented a PostgreSQL interface (PGInterface). With the interface, it is possible to connect to polypheny via the PostgreSQL JDBC driver.


Changes

The interface is mainly isolated from the rest of the code, so apart from the new features, no changes to the existing architecture were done.


Features

  • Ability to create a PGInterface via the UI
  • Connect with a PostgreSQL JDBC driver to Polypheny via the PGInterface
  • Execute queries through this connection

Tests

The tests were implemented in the dbms module.

  • Integration tests for the PGInterface - tests simulate a client who uses PostgreSQL JDBC
  • Some DML, DQL and DDL commands are tested
  • Prepared Statements are tested

ToDo

There are several starting points for future work. Some major points of interest are listed below, and smaller ToDo's are marked in the code.

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
  • Implement SSL - support into Netty (--> enable other authentication methods)
  • Support and test more data types
  • Support and test more SQL commands (mainly TCL and DCL)
  • Improve how incoming messages are categorized
  • Improve how information from the incoming messages is gathered
  • Support Prepared Statement sent via the JDBC framework

@flurfis flurfis added C-enhancement Category: An issue proposing an enhancement A-db Area: DB S-in-progress Still working on this pull request labels Nov 2, 2022
…ible to receive a message from a psql client. But it does not send a correct reply to the client, neither does it anything with the message.
…=9.0), renamed classes, started to implement structure for later
…d/generalized responses the 'server' is sending
…The origin of the number 8 eludes me as of yet...
…n client comes the error: 'Dieses ResultSet ist geschlossen'
…ible to receive a message from a psql client. But it does not send a correct reply to the client, neither does it anything with the message.
…=9.0), renamed classes, started to implement structure for later
…d/generalized responses the 'server' is sending
flurfis and others added 29 commits February 9, 2023 23:17
…The origin of the number 8 eludes me as of yet...
…comments)... as well as bugfix of CommandComplete
…ement, everything is now in place for them to be executed (hopefully)
…or to client, who can read error message, but the errormessage causes an error. but doesnt really matter because the client would terminate the connection anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Area: DB C-enhancement Category: An issue proposing an enhancement S-in-progress Still working on this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants