-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres - Interface #421
Open
flurfis
wants to merge
57
commits into
master
Choose a base branch
from
interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Postgres - Interface #421
+2,611
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flurfis
added
C-enhancement
Category: An issue proposing an enhancement
A-db
Area: DB
S-in-progress
Still working on this pull request
labels
Nov 2, 2022
…ible to receive a message from a psql client. But it does not send a correct reply to the client, neither does it anything with the message.
…=9.0), renamed classes, started to implement structure for later
…d/generalized responses the 'server' is sending
…exception while starting polypheny
… whole). Exception on startup remains
…ut not yet sent correctly to the client
…The origin of the number 8 eludes me as of yet...
…oo many 0 now show up in wireshark
…n client comes the error: 'Dieses ResultSet ist geschlossen'
…ible to receive a message from a psql client. But it does not send a correct reply to the client, neither does it anything with the message.
…=9.0), renamed classes, started to implement structure for later
…d/generalized responses the 'server' is sending
…exception while starting polypheny
… whole). Exception on startup remains
…ut not yet sent correctly to the client
…The origin of the number 8 eludes me as of yet...
…oo many 0 now show up in wireshark
…sponse sent bytewise
…comments)... as well as bugfix of CommandComplete
…about my error handling (internally) yet...
…ement, everything is now in place for them to be executed (hopefully)
…or to client, who can read error message, but the errormessage causes an error. but doesnt really matter because the client would terminate the connection anyway
…nd and added OID of the dataType
…le several values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-db
Area: DB
C-enhancement
Category: An issue proposing an enhancement
S-in-progress
Still working on this pull request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a PostgreSQL interface (PGInterface). With the interface, it is possible to connect to polypheny via the PostgreSQL JDBC driver.
Changes
The interface is mainly isolated from the rest of the code, so apart from the new features, no changes to the existing architecture were done.
Features
Tests
The tests were implemented in the dbms module.
ToDo
There are several starting points for future work. Some major points of interest are listed below, and smaller ToDo's are marked in the code.