-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication #14
Authentication #14
Conversation
86b43df
to
ce5dfc2
Compare
Hey, @vogti. I have completed the following:
I had also written some documentation for the Authentication features in the readme. Let me know if you want me to add something else. I have some points where some improvements can be made.
Thank you. Let me know if any more changes need to be made. |
variable names and made function names more descriptive
auth can be enabled/disabled.
… create passwd file, add auth info, use ClientData to create PolyphenyControlConnector object; Modify PolyphenyControlConnector to take ClientData as contructor parameter, store jsessionid cookie
…nfiguration setting for control;
66e1192
to
2920ad2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, @VishalDalwadi, for this PR!
This PR implements authentication for Polypheny-Control, trying to solve issue 291 Authentication information is stored in
.polypheny/passwd
file. This contains the username and password. The passwords are secured using thecrypt
function. However, the password file itself isn't secured. Users may find it much easier to use different commands on their computers to secure the password file. For eg, setting the immutable flag on Linux systems using the chattr command. To add / remove / modify users the polypheny-control executable has three commandsadduser
,remuser
andmoduser
. They will modify the password file. So, if the file is secured by users using the immutable flag, it would have to be reset before performing these operations.Authentication can be enabled / disabled for local users by using the
localauth.enable
config.A login page has been added to the UI to ask for credentials. If credentials are invalid or is not done, user won't be able to access the index.html page.
This is an update pull request. See initial pull request for previous discussions.
ToDos:
AuthenticationDataManager.java
,AuthenticationFileManager.java
,AuthenticationManager.java
,NotificationManager.java
.auth.local
setting should be set to false on default. This makes it significantly easier to get started with Polypheny Control.passwd
file on startup when started in testing mode and restore an existing backup when started in normal mode.auth.local
enabled and disabled.Closes polypheny/Polypheny-DB#291