pandas 0.23.0 change to types #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `from pandas.api import types`. Changed from `common.is_numeric_dtype` and `common.is_datetime64_dtype` in lines 113 and 116 to `types.---` to make things work with pandas 0.23.0. Not sure if you use `from pandas.core import common` anywhere else in your code but quick test with it removed doesn't seem to break anything. Didn't do extensive testing but does seem to get things working again.
|
Fixed it for me thanks |
|
Thanks for the fix |
|
Great thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #10
Added
from pandas.api import types.Changed from
common.is_numeric_dtypeandcommon.is_datetime64_dtypein lines 113 and 116 totypes.---to make things work with pandas 0.23.0.Not sure if you use
from pandas.core import commonanywhere else in your code but quick test with it removed doesn't seem to break anything.Didn't do extensive testing but does seem to get things working again.