Skip to content

Handle migration from old all-accounts#1110

Merged
polkadot-js-bot merged 1 commit intomasterfrom
jg-auth-previous
Jul 14, 2022
Merged

Handle migration from old all-accounts#1110
polkadot-js-bot merged 1 commit intomasterfrom
jg-auth-previous

Conversation

@jacogr
Copy link
Copy Markdown
Member

@jacogr jacogr commented Jul 14, 2022

Follow-up for #1068

Tested by going to 0.44.1, reject/approve and then running latest

@jacogr jacogr added the -auto label Jul 14, 2022
@polkadot-js-bot polkadot-js-bot merged commit 3956bd5 into master Jul 14, 2022
@polkadot-js-bot polkadot-js-bot deleted the jg-auth-previous branch July 14, 2022 08:31
@Tbaut
Copy link
Copy Markdown
Contributor

Tbaut commented Jul 14, 2022

Interesting, I did not handle the migration as we discussed in the original issue so that users would have to go through the new process and decide whether or not all accounts should be shared, for all websites including the ones they already approved.

@jacogr
Copy link
Copy Markdown
Member Author

jacogr commented Jul 14, 2022

The issue is, once I rolled back to the 0.44.1 branch and then went forward, it was confusing - nothing popped up, but 0 accounts were injected. So I do recall the re-auth, but assumed it would be a popup that asks for it. It never happened. This seemed to be the simplest way around that...

... was really worried about 20 million issues being logged.

(Since I tested with a brand new extension, never had this issue until it went it, so testing sucked a bit :))

@Tbaut
Copy link
Copy Markdown
Contributor

Tbaut commented Jul 14, 2022

re-reading your comment, I understand that this happened when you rolled back. That makes sense, definitely something I didn't test.

@polkadot-js-bot
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants