Handle migration from old all-accounts#1110
Conversation
|
Interesting, I did not handle the migration as we discussed in the original issue so that users would have to go through the new process and decide whether or not all accounts should be shared, for all websites including the ones they already approved. |
|
The issue is, once I rolled back to the 0.44.1 branch and then went forward, it was confusing - nothing popped up, but 0 accounts were injected. So I do recall the re-auth, but assumed it would be a popup that asks for it. It never happened. This seemed to be the simplest way around that... ... was really worried about 20 million issues being logged. (Since I tested with a brand new extension, never had this issue until it went it, so testing sucked a bit :)) |
|
re-reading your comment, I understand that this happened when you rolled back. That makes sense, definitely something I didn't test. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Follow-up for #1068
Tested by going to 0.44.1, reject/approve and then running latest