Skip to content

fix(RemoveAuth): icon cursor & size#1082

Merged
jacogr merged 2 commits intopolkadot-js:masterfrom
roiLeo:fix/RemoveAuth/cursor
Jun 10, 2022
Merged

fix(RemoveAuth): icon cursor & size#1082
jacogr merged 2 commits intopolkadot-js:masterfrom
roiLeo:fix/RemoveAuth/cursor

Conversation

@roiLeo
Copy link
Copy Markdown
Contributor

@roiLeo roiLeo commented Jun 10, 2022

Hello, this PR fix removeAuth button UI, I've:

  • align icon with text
  • reduce icon size
  • remove unused code
  • show cursor

🖼️ screenshot

before
Capture d’écran 2022-06-10 à 10 11 44 AM

after
Capture d’écran 2022-06-10 à 10 05 24 AM

Copy link
Copy Markdown
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested it myself, but the changes look sane.

Thank you!

@jacogr jacogr merged commit 2e70d36 into polkadot-js:master Jun 10, 2022
@Tbaut
Copy link
Copy Markdown
Contributor

Tbaut commented Jun 10, 2022

Late to the party, I fixed this in my approval PR, it'll only conflict minimally.

#1068

@polkadot-js-bot
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 12, 2022
@roiLeo roiLeo deleted the fix/RemoveAuth/cursor branch June 13, 2022 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants