add jupiter testnet#4334
Conversation
| /* eslint-disable sort-keys */ | ||
|
|
||
| export default { | ||
| LookupSource: 'MultiAddress' |
There was a problem hiding this comment.
Shouldn't we also have Address: 'MultiAddress?
There was a problem hiding this comment.
Hi @jacogr
We define for type Address is same to node-template define(pub type Address = sp_runtime::MultiAddress<AccountId, ()>;). Thus there are two points related to this:
-
node-templatehave not changed the define oftypes: { Address: 'AccountId', LookupSource: 'AccountId' }
We think this should be changed after the pr More Extensible Multiaddress Format paritytech/substrate#7380 in substrate,
using:
{ "LookupSource": "MultiAddress", "Address": "LookupSource" }We may create a pr to fix this if you will, or you may have some your own considerations.
-
In our chain, using
polkadot.jswould use default config, thus, innodeconfig, the default already has:"Address": "LookupSource"
thus we just override
LookupSource: 'MultiAddress'is ok. But you are right, override both
LookupSourceandAddressmay be better, we will change later, thanks!
add ```Address: 'MultiAddress'``` types.
|
Hi, @jacogr . I have added the |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
hi there,
this PR is to add jupiter testnet.
greetings!