Update Kulupu Address and LookupSource definitions#4281
Merged
jacogr merged 1 commit intopolkadot-js:masterfrom Dec 29, 2020
Merged
Update Kulupu Address and LookupSource definitions#4281jacogr merged 1 commit intopolkadot-js:masterfrom
jacogr merged 1 commit intopolkadot-js:masterfrom
Conversation
jacogr
approved these changes
Dec 29, 2020
Member
jacogr
left a comment
jacogr
left a comment
There was a problem hiding this comment.
Thank you.
It probably makes sense to move this to versioned types, i.e. based on the specVersion. Examples with min/max - https://github.com/polkadot-js/apps/blob/master/packages/apps-config/src/api/bundle/spec/moonbeam.ts
That means it can be done anytime before the upgrade and just takes effect,
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime just today was updated to include the new MultiAddress support paritytech/substrate#7380 and hence we need to update the type definitions.