Show the amount of token that will be claimed#2747
Merged
Tbaut merged 4 commits intotbaut-attestfrom May 14, 2020
Merged
Conversation
amaury1093
reviewed
May 14, 2020
| isPrimary | ||
| label={t('Attest')} | ||
| params={['dsafdsalkfj']} // Replace with actual | ||
| params={[statementKind]} // Replace with actual |
Contributor
There was a problem hiding this comment.
iiuc, we shouldn't attest the statementKind, but the actual statement in english: https://github.com/paritytech/polkadot/pull/1091/files#diff-6713ee0e82ee03f026aa21e5e99fb055R66
i.e. statementKind is an Enum, but we should put here the string matching the enum
Contributor
There was a problem hiding this comment.
We can leave as-is for now, as anything will work, we it should probably be replaced at some point with hardcoded strings like:
statementKind.siDefault() ? 'statement1' : 'statement2'
Contributor
Author
There was a problem hiding this comment.
yup absolutely, that's my understanding as well. Although right now the statement === statemendKind
amaury1093
added a commit
that referenced
this pull request
May 26, 2020
* init * Attest component * Add top notification bar * better english * back to 3 steps * clean up * in the middle of the refactoring * Make TS pass * Clea up some comments * isPreclaimed * isOldClaimProcess * Attest vs Claim (#2737) * Choose between Claim and Attest * fix lint * fix flow between claim and attest (#2738) * Jaco's comments + Fetch StatementKind (#2741) * Fix small bug in flow * Add condition for the warning banner (#2742) * prevent crash for older chains * with useEffect * should work * back to something simple * remove hoc * fix CI * Add ETH address field for non preclaimed addresses (#2746) * Eth field * fix * remove stray logs * Update packages/page-claims/src/index.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * Update packages/page-claims/src/index.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * Update packages/apps/src/overlays/Attest.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * Show the amount of token that will be claimed (#2747) * show amount in attest * fix isApiReady * fix lint * Use counter instead of overlay (#2750) * Use counter instead of overlay * Add warning to claim (#2752) * add warning * css cleanup * fix unused const Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/page-claims/src/Warning.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * Update packages/page-claims/src/index.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * Update packages/page-claims/src/index.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * Update packages/page-claims/src/index.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * Update packages/page-claims/src/index.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * address comment shortcut * set Ethereum address outside transfor and fix typos * lint * extract claims.preclaims to a hook * address comments EthereumAddress type and avoid casting * Missing isUnsigned * use AddressMini in warning * use a proper step for eth address field * Add loading state * remove log * unwrapOrNull * Update packages/page-claims/src/Warning.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * fix for account plural translation * lint * Add getStatement function * nits * Fix lint * Update packages/page-claims/src/Warning.tsx Co-authored-by: Jaco Greeff <jacogr@gmail.com> * add statement * statement component * address comment unWrapOr * test styling with long md * add md to jest * Update packages/page-claims/src/Statement.tsx Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> * copy text before * lint * Remove EthreumAddress type to avoid unexpected behaviors (#2796) * remove EthreumAddress type * createType when needed * revert * typo * Enhance UX for claim process (#2797) * update content * init * comment * Add HTML components for statements (#2798) * Add HTML components for statements * Update packages/page-claims/src/statements/saft.tsx * Update to final statements * More nits * Nits * OnSuccess * prevent display of empty statement when attested * Small fixmes * Update packages/page-claims/src/index.tsx * fix isError not being red as expected * remove word-break * statement text in black * attestation for -> accounc balance * Update packages/page-claims/src/Statement.tsx Co-authored-by: Logan Saether <x@logansaether.com> * margin left instead of space * I agree * Use iframe * update saft to QmXEkMahfhHJPzT3RjkXiZVFi77ZeVeuxtAjhojGRNYckz * remove hash and duplications (#2814) Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Jaco Greeff <jacogr@gmail.com> Co-authored-by: Logan Saether <x@logansaether.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged in
tbaut-attest