Skip to content

Remove snippet sharing #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacogr merged 1 commit into from
Jan 17, 2020
Merged

Remove snippet sharing #2138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/app-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"license": "Apache-2.0",
"dependencies": {
"@babel/runtime": "^7.7.7",
"@polkadot/react-components": "^0.39.0-beta.60",
"snappyjs": "^0.6.0"
"@polkadot/react-components": "^0.39.0-beta.60"
}
}
36 changes: 5 additions & 31 deletions packages/app-js/src/ActionButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,38 +2,29 @@
// This software may be modified and distributed under the terms
// of the Apache-2.0 license. See the LICENSE file for details.

import { BareProps, I18nProps } from '@polkadot/react-components/types';
import { BareProps } from '@polkadot/react-components/types';

import React, { useState } from 'react';
import styled from 'styled-components';
import { Button as SUIB, Popup } from 'semantic-ui-react';
import { Button, Input } from '@polkadot/react-components';

import translate from './translate';
import { useTranslation } from './translate';

interface Props extends BareProps, I18nProps {
interface Props extends BareProps {
isCustomExample: boolean;
isRunning: boolean;
generateLink: () => void;
removeSnippet: () => void;
runJs: () => void;
saveSnippet: (snippetName: string) => void;
snippetName?: string;
stopJs: () => void;
}

function ActionButtons ({ className, generateLink, isCustomExample, isRunning, removeSnippet, runJs, saveSnippet, stopJs, t }: Props): React.ReactElement<Props> {
export default function ActionButtons ({ className, isCustomExample, isRunning, removeSnippet, runJs, saveSnippet, stopJs }: Props): React.ReactElement<Props> {
const { t } = useTranslation();
const [isOpen, setIsOpen] = useState(false);
const [shareText, setShareText] = useState(t('Generate link to share code example'));
const [snippetName, setSnippetName] = useState('');

const _generateLink = (): void => {
setShareText(t('Copied to clipboard'));
generateLink();
};
const _onShareClose = (): void => {
setShareText(t('Generate link to share code example'));
};
const _onChangeName = (snippetName: string): void => {
setSnippetName(snippetName);
};
Expand All @@ -51,19 +42,6 @@ function ActionButtons ({ className, generateLink, isCustomExample, isRunning, r

return (
<div className={`${className} action-button`}>
<Popup
content={shareText}
on='hover'
onClose={_onShareClose}
trigger={
<SUIB
circular
icon='share alternate'
onClick={_generateLink}
/>
}
wide='very'
/>
{
// FIXME: The <Popup /> event trigger on='hover' does not work together with the ui-app'
// <Button /> component. That's why the original Semantic UI component is being used here.
Expand Down Expand Up @@ -137,7 +115,3 @@ function ActionButtons ({ className, generateLink, isCustomExample, isRunning, r
</div>
);
}

export default translate(
styled(ActionButtons)``
);
Loading