Skip to content

fix: Fixes #1986 proposals of undefined #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacogr merged 3 commits into from
Dec 3, 2019
Merged

fix: Fixes #1986 proposals of undefined #1987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07b7fea
fix: Fixes #1986 proposals of undefined
ltfschoen Dec 2, 2019
e86c535
fix: Prevent undefined proposals in packages/app-council/src/useCount…
ltfschoen Dec 3, 2019
8a19c71
fix: Revert change since api.derive.democracy is always defined
ltfschoen Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app-council/src/useCounter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { useApi, trackStream } from '@polkadot/react-hooks';

export default function useCounter (): number {
const { api, isApiReady } = useApi();
const motions = trackStream<Hash[]>(isApiReady ? api.query.council.proposals : undefined, []);
const motions = trackStream<Hash[]>(isApiReady ? api.query.council?.proposals : undefined, []);
const [counter, setCounter] = useState(0);

useEffect((): void => {
Expand Down
2 changes: 1 addition & 1 deletion packages/app-tech-comm/src/useCounter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { useApi, trackStream } from '@polkadot/react-hooks';

export default function useCounter (): number {
const { api, isApiReady } = useApi();
const proposals = trackStream<Hash[]>(isApiReady ? api.query.technicalCommittee.proposals : undefined, []);
const proposals = trackStream<Hash[]>(isApiReady ? api.query.technicalCommittee && api.query.technicalCommittee.proposals : undefined, []);
Copy link
Copy Markdown
Member

@jacogr jacogr Dec 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const proposals = trackStream<Hash[]>(isApiReady ? api.query.technicalCommittee && api.query.technicalCommittee.proposals : undefined, []);
const proposals = trackStream<Hash[]>(isApiReady ? api.query.technicalCommittee?.proposals : undefined, []);

Copy link
Copy Markdown
Contributor Author

@ltfschoen ltfschoen Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the suggested change here should be the following:

api.query.technicalCommittee?.proposals

Instead of:

api.query.technicalCommittee?.technicalCommittee.proposals

Otherwise I still get error Uncaught TypeError: Cannot read property proposals of undefined

Copy link
Copy Markdown
Member

@jacogr jacogr Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little edit boxes :)

const [counter, setCounter] = useState(0);

useEffect((): void => {
Expand Down