Skip to content

Method: don't use globals#1350

Closed
axelchalon wants to merge 2 commits intomasterfrom
ac-method-no-global
Closed

Method: don't use globals#1350
axelchalon wants to merge 2 commits intomasterfrom
ac-method-no-global

Conversation

@axelchalon
Copy link

@axelchalon axelchalon commented Jun 25, 2019

Use the pure function findByCallIndex introduced in polkadot-js/api#1047 instead of findFunction relying on injected globals.

(Need to update the dependency once the api PR is merged)

@jacogr
Copy link
Member

jacogr commented Nov 23, 2019

Closing. The API interface has been changed around this by passing the registry around, and using the registry for lookups.

@jacogr jacogr closed this Nov 23, 2019
@jacogr jacogr deleted the ac-method-no-global branch November 23, 2019 21:21
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants