This repository was archived by the owner on Jul 14, 2023. It is now read-only.
Merged
Conversation
209d4ff to
9ba8516
Compare
Collaborator
|
I support @ordian for III Dan |
Contributor
|
I'm glad to see there's a PR which is sufficiently large as to be considered "substantial" by the manifesto's definition of III Dan requirements. Based on this, the volume of core code written and the expertise which it requires, together with the fact that non-trivial contributions date back to early 2019 (even if not full-time), I think III Dan rank is perfectly reasonable. |
gavofyork
approved these changes
Sep 27, 2022
Author
For the record, I've been working at Parity for over 4 years full-time, but initially mostly on ethereum-related code. |
bkchr
approved these changes
Sep 27, 2022
jacogr
approved these changes
Sep 27, 2022
rphmeier
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on the Parachains consensus team (aka Parachains-core) since mid 2020, but my early ecosystem contributions were to https://github.com/paritytech/parity-common which contained core crates shared between Ethereum (called
parityat the time) and Substrate clients and dates back to early 2019, that I've been maintaining since then. As a student of the guide, I've designed and implemented validator discovery used by collators and validators, grid topology for optimized networking, disputes rewards and slashing mechanism, introduced Prometheus metrics to Polkadot, implemented several subsystems and reviewed most of them.Some notable PRs:
uintto match the performance of GMP in the worst cases)Besides PRs, I've reviewed numerous PRs (incl. finding issues in Grand Architect's code), spent countless hours investigating and fixing issues on testnets, participated in technical discussions, interviewing, onboarding new people and knowledge sharing.
Given the above, I'd apply to either Dan 4 or 3 at your discretion.