Fix depencencies#996
Merged
claravanstaden merged 2 commits intoNov 4, 2025
Merged
Conversation
Contributor
Author
clangenb
force-pushed
the
cl/fix-dependencies
branch
from
081b30e to
af79daf
Compare
clangenb
commented
Nov 4, 2025
Comment on lines
218
to
+234
| @@ -231,7 +231,7 @@ snowbridge-inbound-queue-primitives = { version = "0.5.0", default-features = fa | |||
| snowbridge-runtime-common = { version = "0.17.0", default-features = false } | |||
| snowbridge-runtime-test-common = { version = "0.19.0" } | |||
| snowbridge-system-runtime-api = { version = "0.16.0", default-features = false } | |||
| snowbridge-system-v2-runtime-api = { version = "0.4.0", default-features = false } | |||
| snowbridge-system-v2-runtime-api = { version = "0.5.0", default-features = false } | |||
Contributor
Author
There was a problem hiding this comment.
@claravanstaden psvm --version polkadot-stable2509-1 yielded this. Can you confirm that this is ok?
Contributor
There was a problem hiding this comment.
This is 100%, thank you!
claravanstaden
approved these changes
Nov 4, 2025
claravanstaden
merged commit 8796319
into
polkadot-fellows:pandres95-upgrade-to-stable2509
16 of 71 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the dependency mess that we still have in the update branch.
The issues with encointer's dependencies was that we only introduced patch bumps for the stable202509 upgrade to keep being aligned with the polkadot-sdk releases (we messed up the rhythm, as the unstable branch was a major release for us). The patch bump did not propagate to our innermost dependencies in the lock file, as it was deemed compatible with the ones explicitly defined in the root toml.
So this PR fixes (I believe all) of the duplicate substrate dependencies by running
cargo update -p encointer-crates-at-wrong-versionpsvm --version polkadot-stable2509-1