Skip to content

Conversation

@yrong
Copy link
Contributor

@yrong yrong commented Oct 20, 2025

It looks like we missed some of the runtime API when initially merging it into fellows-runtime in PR-796, this API is required to generate proofs.

@acatangiu
Copy link
Contributor

code changes look good, but CHANGELOG is messed up

We may need to apply the patch to the production branch as well as the subsequent release branches.

also, this repo doesn't use release branches since runtime artifacts are "only used once", each new release makes the previous one irrelevant/never-used-again

@bkontur
Copy link
Contributor

bkontur commented Oct 20, 2025

code changes look good, but CHANGELOG is messed up

I would just revert the CHANGELOG changes (some local formatting - zepter?) and:

  • either add here just one note:
## [Unreleased]

### Fixed

- [BHP](https://github.com/polkadot-fellows/runtimes/pull/978) Add missing snowbridge runtime API to the BridgeHub
  runtime.
  • or add this to the Description:
- [x] Does not require a CHANGELOG entry

@yrong Are these runtimeApis relevant just for the relayer or dApps?

@yrong yrong force-pushed the snowbridge-v2-missing-apis branch from e36e401 to e3a200b Compare October 20, 2025 17:23
@yrong
Copy link
Contributor Author

yrong commented Oct 20, 2025

Are these runtimeApis relevant just for the relayer or dApps?

Yeah, it’s only for the relayer.

@github-actions
Copy link

Review required! Latest push from author must always be reviewed

@acatangiu
Copy link
Contributor

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) October 21, 2025 06:55
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 6ca2cd8 into polkadot-fellows:main Oct 21, 2025
65 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants