asset-hub-kusama: use inmemorydb weights#918
Conversation
Modify asset-hub-kusama to use the read/write costs in validate block on validator reference hardware, since these are weights that guarantee the blocks will pass validation and make it on the relay chain. This were obtained with the benchmark created here: paritytech/polkadot-sdk#8069. Part of: paritytech/polkadot-sdk#6131 Fixes: polkadot-fellows#800 Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
|
How big of a change is this? I would like to avoid including big changes with the AHM runtime upgrade since we will do AHM Kusama very soon. |
@ggwpez, The whole point of this change is improving throughput for the SCC launch, which is after AHM migration, so I would say it can be merged after AHM Kusama happens. |
|
if not urgent, let merge this after the AHM release. if this merged we need to adjust some weights on RC side (control flow mechanics accounting for AH weights) and test it. |
ACK, marked it as DNM so that it merges after AHM release. |
alexggh
changed the title
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
alexggh
changed the title
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
|
Review required! Latest push from author must always be reviewed |
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
| @@ -0,0 +1,108 @@ | |||
| //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 49.1.0 | |||
| //! DATE: 2025-09-10 (Y/M/D) | |||
| //! HOSTNAME: `versi-developer-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz` | |||
There was a problem hiding this comment.
@alexggh we should probably also adjust cmd bench bot and re-trigger with other benchmarks/weights when doing releases, right?
There was a problem hiding this comment.
These read/write weights, does not affect the results of the computed per-extrinsics weights, so no need to re-run them.
Yes, bench bot should be updated to also re-run these benchmarks every now and then and there is an issue for that #992.
7 participants
Modify asset-hub-kusama to use the read/write costs computed in validate block on validator reference hardware, since these are weights that guarantee the blocks will pass validation and make it on the relay chain.
This were obtained with the benchmark created here: paritytech/polkadot-sdk#8069.
Part of: #800