Improve logging runtime packaging and naming#869
Merged
Conversation
raymondkfcheung
changed the title
bkontur
reviewed
Aug 27, 2025
bkontur
reviewed
Aug 27, 2025
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
bkontur
reviewed
Aug 27, 2025
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Open
24 tasks
bkontur
approved these changes
Aug 27, 2025
acatangiu
approved these changes
Aug 28, 2025
|
Review required! Latest push from author must always be reviewed |
bkchr
requested changes
Sep 2, 2025
| pattern: '*-compact' | ||
|
|
||
| - name: Create compact-wasms.zip | ||
| - name: Create try-runtime and logging enabled runtimes |
Contributor
There was a problem hiding this comment.
Please rename all these "compact-wasm" stuff to "debug-builds". "Compact" makes no sense and is really confusing when reading this file.
bkontur
approved these changes
Sep 26, 2025
1 task
Contributor
|
@raymondkfcheung we should also rename (remove/change compact): |
raymondkfcheung
commented
Sep 26, 2025
| env: | ||
| PROD_FEATURES: "--features on-chain-release-build" | ||
| COMPACT_FEATURES: "--features try-runtime,metadata-hash" | ||
| TRY_RUNTIME_LOGGING_FEATURES: "--features try-runtime,metadata-hash" |
raymondkfcheung
commented
Sep 26, 2025
| ${{ steps.srtool_build.outputs.wasm_compressed }} | ||
|
|
||
| - name: Build ${{ matrix.runtime.name }} (compact) | ||
| - name: Build ${{ matrix.runtime.name }} (try-runtime & logging) |
raymondkfcheung
commented
Sep 26, 2025
| uses: chevdor/srtool-actions@v0.8.0 | ||
| env: | ||
| BUILD_OPTS: ${{ env.COMPACT_FEATURES }} | ||
| BUILD_OPTS: ${{ env.TRY_RUNTIME_LOGGING_FEATURES }} |
raymondkfcheung
commented
Sep 26, 2025
| profile: "release" | ||
|
|
||
| - name: Upload ${{ matrix.runtime.name }} Wasm (compact) | ||
| - name: Upload ${{ matrix.runtime.name }} Wasm (try-runtime & logging) |
raymondkfcheung
commented
Sep 26, 2025
| chain: ${{ matrix.runtime.name }} | ||
| package: ${{ matrix.runtime.package }} | ||
| runtime_dir: ${{ matrix.runtime.path }} | ||
| profile: "release" |
Contributor
Author
Contributor
There was a problem hiding this comment.
just out of curiosity, production is without logging, why/where is this configured?
[profile.release]
# Polkadot runtime requires unwinding.
panic = "unwind"
opt-level = 3
[profile.production]
inherits = "release"
lto = true
codegen-units = 1
Contributor
Author
There was a problem hiding this comment.
I've no ideas where the config is. When I download production runtimes, there is no logging-enabled. But with release runtimes, there are logging-enabled.
Contributor
There was a problem hiding this comment.
productionis without logging, why/where is this configured?
This is a feature enabled for the runtimes.
bkchr
approved these changes
Nov 4, 2025
pepoviola
pushed a commit
to pepoviola/polkadot-fellows-runtimes
that referenced
this pull request
Nov 12, 2025
Updates job name and archive naming for better clarity of logging-enabled runtime builds. Continues polkadot-fellows#767, closes polkadot-fellows#268 - [x] Does not require a CHANGELOG entry --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates job name and archive naming for better clarity of logging-enabled runtime builds.
Continues #767, closes #268