Fix for benchmarking nits#855
Merged
Merged
Conversation
AutoRebagNumber benchmark setup for Polkadot
Contributor
|
About key deposit, we agreed elsewhere to set it to 0. Can you also adjust this line in the release note to:
|
9 tasks
kianenigma
reviewed
Aug 18, 2025
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
acatangiu
approved these changes
Aug 18, 2025
ggwpez
reviewed
Aug 18, 2025
| type Currency = Balances; | ||
| type KeyDeposit = KeyDeposit; | ||
| // TODO: we will set this post-AHM | ||
| type KeyDeposit = (); |
Member
There was a problem hiding this comment.
We can make this controllable by the rc-migrator pallet that will automatically enable it after the migration.
Will do when its possible.
ggwpez
approved these changes
Aug 18, 2025
github-merge-queue Bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Aug 19, 2025
Fixes the benchmarking code of `pallet_session` such that it works with any `KeyDeposit`. Reported by @bkontur in polkadot-fellows/runtimes#855 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
github-merge-queue Bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Aug 20, 2025
Fixes the benchmarking code of `pallet_session` such that it works with any `KeyDeposit`. Reported by @bkontur in polkadot-fellows/runtimes#855 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
fellowship-merge-bot Bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
This PR contains fresh weights based on Adrian's PR: #849 - [X] Does not require a CHANGELOG entry ## TODO - [x] kusama - [x] polkadot - [x] kusama system paras - [x] polkadot system paras - [x] reran pallet_session::set_keys, runtime_parachains::disputes::slashing (#855) - [x] reran bridge-hub-polkadot / asset-hub-polkadot (because of Snowbridge v2) - [x] ~reran asset-hub-kusama~ (because of Snowbridge v2 and revive) (as a part of #857) - [x] coretimes for allowed reserves --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>
pepoviola
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Aug 26, 2025
Fixes the benchmarking code of `pallet_session` such that it works with any `KeyDeposit`. Reported by @bkontur in polkadot-fellows/runtimes#855 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
alvicsam
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Oct 17, 2025
Fixes the benchmarking code of `pallet_session` such that it works with any `KeyDeposit`. Reported by @bkontur in polkadot-fellows/runtimes#855 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains benchmarking nits and fixes.
pallet_bags_listwhere benchmarks fails forAutoRebagNumber = 0(https://github.com/polkadot-fellows/runtimes/actions/runs/17017979638/job/48243408516)promote_fast- rewrites u16 to u32 which does not compile