Skip to content

Fix for benchmarking nits#855

Merged
acatangiu merged 6 commits into
polkadot-fellows:mainfrom
bkontur:bko-fix-benchmarks
Aug 19, 2025
Merged

Fix for benchmarking nits#855
acatangiu merged 6 commits into
polkadot-fellows:mainfrom
bkontur:bko-fix-benchmarks

Conversation

@bkontur
Copy link
Copy Markdown
Contributor

@bkontur bkontur commented Aug 18, 2025

This PR contains benchmarking nits and fixes.

The following 3 benchmarks failed:
- pallet_session::purge_keys
- pallet_session::set_keys
- runtime_parachains::disputes::slashing::report_dispute_lost_unsigned
Error: Input("3 benchmarks failed")
  • promote_fast - rewrites u16 to u32 which does not compile
    • probably needs polkadot-sdk fix (need to investigate and create polkadot-sdk issue)
  • Does not require a CHANGELOG entry

@bkontur bkontur changed the title Fix AutoRebagNumber benchmark setup for Polkadot Fix for benchmarking nits Aug 18, 2025
@kianenigma
Copy link
Copy Markdown
Contributor

About key deposit, we agreed elsewhere to set it to 0.

Can you also adjust this line in the release note to:

Setting session keys now might charge a storage deposit. The amount can be inspected in the Session::KeyDeposit of the runtime metadata. This value is intended to be set post AHM. Validators should make sure they have some free balance to cover this deposit the next time they want to rotate their keys.

Comment thread CHANGELOG.md Outdated
bkontur and others added 2 commits August 18, 2025 14:52
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Comment thread relay/kusama/src/lib.rs
type Currency = Balances;
type KeyDeposit = KeyDeposit;
// TODO: we will set this post-AHM
type KeyDeposit = ();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this controllable by the rc-migrator pallet that will automatically enable it after the migration.
Will do when its possible.

@acatangiu acatangiu merged commit 53c8d08 into polkadot-fellows:main Aug 19, 2025
54 of 67 checks passed
@acatangiu acatangiu deleted the bko-fix-benchmarks branch August 19, 2025 07:51
github-merge-queue Bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Aug 19, 2025
Fixes the benchmarking code of `pallet_session` such that it works with
any `KeyDeposit`.

Reported by @bkontur in
polkadot-fellows/runtimes#855

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
github-merge-queue Bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Aug 20, 2025
Fixes the benchmarking code of `pallet_session` such that it works with
any `KeyDeposit`.

Reported by @bkontur in
polkadot-fellows/runtimes#855

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
fellowship-merge-bot Bot pushed a commit that referenced this pull request Aug 20, 2025
This PR contains fresh weights based on Adrian's PR:
#849



- [X] Does not require a CHANGELOG entry


## TODO
- [x] kusama
- [x] polkadot
- [x] kusama system paras
- [x] polkadot system paras
- [x] reran pallet_session::set_keys,
runtime_parachains::disputes::slashing
(#855)
- [x] reran bridge-hub-polkadot / asset-hub-polkadot (because of
Snowbridge v2)
- [x] ~reran asset-hub-kusama~ (because of Snowbridge v2 and revive) (as
a part of #857)
- [x] coretimes for allowed reserves

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
pepoviola pushed a commit to paritytech/polkadot-sdk that referenced this pull request Aug 26, 2025
Fixes the benchmarking code of `pallet_session` such that it works with
any `KeyDeposit`.

Reported by @bkontur in
polkadot-fellows/runtimes#855

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
alvicsam pushed a commit to paritytech/polkadot-sdk that referenced this pull request Oct 17, 2025
Fixes the benchmarking code of `pallet_session` such that it works with
any `KeyDeposit`.

Reported by @bkontur in
polkadot-fellows/runtimes#855

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants