Upgrade to Polkadot-SDK `stable2506` by acatangiu · Pull Request #817 · polkadot-fellows/runtimes

acatangiu · 2025-07-16T16:27:10Z

This brings in stable2506 Polkadot SDK, and integrates many new features.

Integrated breaking changes to be verified by the original authors:

…#7592)

… #8281

acatangiu · 2025-07-17T12:49:57Z

@brenzi please help with encointer dependencies, we need new version of the encointer pallets and primitives also based on stable2506

alexggh · 2025-08-01T15:23:41Z

@alexggh @alindima can one of you help with this failing test in CI?

The following 1 benchmarks failed:
- runtime_parachains :: disputes :: slashing::report_dispute_lost_unsigned
Error: Input("1 benchmarks failed")
Error: Process completed with exit code 1.

@Overkillus, @ordian: Any idea ?

bkontur · 2025-08-01T21:20:15Z

@alexggh @alindima can one of you help with this failing test in CI?
The following 1 benchmarks failed:
- runtime_parachains :: disputes :: slashing::report_dispute_lost_unsigned
Error: Input("1 benchmarks failed")
Error: Process completed with exit code 1.
@Overkillus, @ordian: Any idea ?

https://github.com/polkadot-fellows/runtimes/actions/runs/16673725543/job/47205674825?pr=817#step:10:107

2025-08-01T14:38:52.622374Z ERROR polkadot_sdk_frame::benchmark::pallet: Benchmark runtime_parachains :: disputes :: slashing::report_dispute_lost_unsigned failed: InvalidKeyOwnershipProof

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

bkchr · 2025-08-05T21:04:58Z


 	// see the `FEE_BOOST_PER_MESSAGE` constant to get the meaning of this value
-	pub PriorityBoostPerMessage: u64 = 182_044_444_444_444;
+	pub PriorityBoostPerMessage: u64 = 328_162_135_442_412;


Looks like a big increase?

This is coming from doubling the POV size. It is only a relayer tx priority boost so I believe it is ok.

more details here paritytech/polkadot-sdk#5884 (comment)

alexggh · 2025-08-06T15:15:36Z

@alexggh @alindima can one of you help with this failing test in CI?
The following 1 benchmarks failed:
- runtime_parachains :: disputes :: slashing::report_dispute_lost_unsigned
Error: Input("1 benchmarks failed")
Error: Process completed with exit code 1.
@Overkillus, @ordian: Any idea ?

I looked a bit at this benchmark, first the benchmarks seems to be ok on polkadot-sdk with the westend runtime, so I would presume there must be something from the polkadot runtime configuration, I did some debugging and the proof seems to be indeed invalid.

The reason the proof is invalid is that T::FullIdentification for test validators seems to be changing between the moment they get snapshotted at the beginning of the session here: https://github.com/paritytech/polkadot-sdk/blob/cf5a24ecc5802ecf78d943f9723b6f4ccdc0ddfa/substrate/frame/session/src/historical/mod.rs#L202

And the moment we generate the proof in the benchmark here: https://github.com/paritytech/polkadot-sdk/blob/cf5a24ecc5802ecf78d943f9723b6f4ccdc0ddfa/substrate/frame/session/src/historical/mod.rs#L345.

Then proof fails to check because it has a different root than the one used here: https://github.com/paritytech/polkadot-sdk/blob/cf5a24ecc5802ecf78d943f9723b6f4ccdc0ddfa/substrate/frame/session/src/historical/mod.rs#L374.

@Ank4n you seem to have been touching last this benchmark, https://github.com/paritytech/polkadot-sdk/blob/cf5a24ecc5802ecf78d943f9723b6f4ccdc0ddfa/polkadot/runtime/parachains/src/disputes/slashing/benchmarking.rs#L88, any chance this was something to do with the new staking changes ?

Ank4n · 2025-08-06T15:29:56Z

@alexggh @alindima can one of you help with this failing test in CI?

The following 1 benchmarks failed:
- runtime_parachains :: disputes :: slashing::report_dispute_lost_unsigned
Error: Input("1 benchmarks failed")
Error: Process completed with exit code 1.

@Ank4n you seem to have been touching last this benchmark, https://github.com/paritytech/polkadot-sdk/blob/cf5a24ecc5802ecf78d943f9723b6f4ccdc0ddfa/polkadot/runtime/parachains/src/disputes/slashing/benchmarking.rs#L88, any chance this was something to do with the new staking changes ?

Could you update the following? I believe it will fix the error.

type FullIdentificationOf = pallet_staking::DefaultExposureOf<Runtime>.

Overkillus · 2025-08-06T15:47:50Z

type FullIdentificationOf = pallet_staking::DefaultExposureOf<Runtime>

That seemed to fix it. I assume this should be added to both Kusama and Polkadot RLCs. All benches run correctly now after testing the fix locally.

acatangiu · 2025-08-06T19:10:07Z

type FullIdentificationOf = pallet_staking::DefaultExposureOf<Runtime>

That seemed to fix it. I assume this should be added to both Kusama and Polkadot RLCs. All benches run correctly now after testing the fix locally.

You can open a PR against this branch on my fork to get the fix in. Otherwise I will push it myself later tomorrow

FullIdentificationOf bump on both RLCs

acatangiu · 2025-08-07T08:55:30Z

/merge

fellowship-merge-bot · 2025-08-07T09:04:22Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

acatangiu · 2025-08-07T09:04:45Z

/cmd fmt

github-actions · 2025-08-07T09:35:12Z

Command "fmt" has started 🚀 See logs here

github-actions · 2025-08-07T09:37:13Z

Command "fmt" has failed ❌! See logs here

acatangiu added 26 commits July 15, 2025 18:53

bump rust to 1.88.0 to support 2024 edition crates

fb354c6

bump to SDK stable2506

1771cbc

update 3rd party deps

4c265ff

manually bump missed polkadot SDK deps

05c1783

integrate [AHM] Async Staking module across AH and RC #8127

bb78e33

integrate CreateBare, deprecated CreateInherent (#7597)

76e9c59

integrate remove_upgrade_cooldown (#8254)

047069c

integrate Paras authorize_code_hash + apply_authorized_code feature (…

8e83aab

…#7592)

integrate poke_deposit extrinsic to pallet-bounties (#8382)

b9755e3

Integrate the above for kusama as well

29e1373

fix more SDK dependencies bumps

a25c034

integrate XCMP improvements (#7963, #8021, #8344)

6831d00

integrate pallet-revive (#8262, #8584)

2185879

integrate impl_revive_api macro #8652

1347f06

integrate building on older relay parents #8299

2bfcc1c

integrate pallet-assets ERC20 precompile #8554

c91a52f

integrate pre-compile framework (#8262)

2e51a06

fix more dependencies

0b6b81c

integrate XcmPaymentApi::query_weight_to_asset_fee simple common impl…

f4a89aa

… #8281

integrate Nest errors in pallet-xcm #7730

15bfdbc

fix more dependencies

23426f0

integrate Snowbridge: Unpaid execution when bridging to Ethereum #8599

032f21a

integrate Added OnNewHead to pallet-bridge-parachains #8531

31af36b

remove unused imports

0feb7fa

temporarily disable failing tests

7fc608a

integrate check XCM size in VMP routing #8409

5cc1498

acatangiu marked this pull request as draft July 16, 2025 16:27

acatangiu changed the title ~~[WIP] Bump repo dependencies to Polkadot-SDK stable2506~~ [WIP] Upgrade to Rust 1.88 and Polkadot-SDK stable2506 Jul 17, 2025

fix tests

66bd75a

serban300 approved these changes Aug 4, 2025

View reviewed changes

joepetrowski reviewed Aug 5, 2025

View reviewed changes

acatangiu mentioned this pull request Aug 5, 2025

[debt] remove InspectMessageWrapper and use upstream UnpaidRemoteExporter #837

Closed

acatangiu commented Aug 5, 2025

View reviewed changes

Comment thread system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs Outdated

Comment thread system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs Outdated

acatangiu and others added 2 commits August 5, 2025 11:00

Apply suggestions from code review

313eaa3

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Apply suggestions from code review

0d6317a

joepetrowski approved these changes Aug 5, 2025

View reviewed changes

bkchr approved these changes Aug 5, 2025

View reviewed changes

acatangiu added 3 commits August 6, 2025 16:43

fix fmt

89a61e0

fix TODO

b735c2a

pallet-revive benchmarks broken, use SubstrateWeights

7522ff0

Overkillus and others added 2 commits August 7, 2025 09:48

fullid bump on both rlcs

97649f6

Merge pull request #10 from Overkillus/mkz-fullid-bump

882016e

FullIdentificationOf bump on both RLCs

fellowship-merge-bot Bot enabled auto-merge (squash) August 7, 2025 09:04

fix fmt

22f383f

fellowship-merge-bot Bot merged commit d6c5bd3 into polkadot-fellows:main Aug 7, 2025
61 checks passed

github-project-automation Bot moved this from Review to Done in Runtime releases Aug 7, 2025

acatangiu deleted the bump-sdk-2506 branch November 7, 2025 19:01

acatangiu restored the bump-sdk-2506 branch November 7, 2025 19:01

Uh oh!

Conversation

acatangiu commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acatangiu commented Jul 17, 2025

Uh oh!

alexggh commented Aug 1, 2025

Uh oh!

bkontur commented Aug 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkchr Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

acatangiu Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

alexggh commented Aug 6, 2025

Uh oh!

Ank4n commented Aug 6, 2025

Uh oh!

Overkillus commented Aug 6, 2025

Uh oh!

acatangiu commented Aug 6, 2025

Uh oh!

acatangiu commented Aug 7, 2025

Uh oh!

fellowship-merge-bot Bot commented Aug 7, 2025

Uh oh!

acatangiu commented Aug 7, 2025

Uh oh!

github-actions Bot commented Aug 7, 2025

Uh oh!

github-actions Bot commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

acatangiu commented Jul 16, 2025 •

edited

Loading