Fix revive-fixtures CI#785
Closed
ggwpez wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
github-merge-queue Bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Jun 25, 2025
The .polkavm files are not recompiled when deleting `target/pallet-revive-fixtures`. I assume that CI is not caching that folder or the .polkavm file extension. This leads to the `include_bytes!` macro to not finding these files. Tested it here polkadot-fellows/runtimes#785 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
paritytech-release-backport-bot Bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Jun 25, 2025
The .polkavm files are not recompiled when deleting `target/pallet-revive-fixtures`. I assume that CI is not caching that folder or the .polkavm file extension. This leads to the `include_bytes!` macro to not finding these files. Tested it here polkadot-fellows/runtimes#785 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Theißen <alex.theissen@me.com> (cherry picked from commit e774263)
paritytech-release-backport-bot Bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Jun 26, 2025
The .polkavm files are not recompiled when deleting `target/pallet-revive-fixtures`. I assume that CI is not caching that folder or the .polkavm file extension. This leads to the `include_bytes!` macro to not finding these files. Tested it here polkadot-fellows/runtimes#785 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Theißen <alex.theissen@me.com> (cherry picked from commit e774263)
Member
Author
|
works |
alvicsam
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Oct 17, 2025
The .polkavm files are not recompiled when deleting `target/pallet-revive-fixtures`. I assume that CI is not caching that folder or the .polkavm file extension. This leads to the `include_bytes!` macro to not finding these files. Tested it here polkadot-fellows/runtimes#785 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNM need to check that the fix works first.