Max PoV size 10mb for Kusama Asset Hub and People chains#718
Closed
muharem wants to merge 9 commits intopolkadot-fellows:mainfrom
Closed
Max PoV size 10mb for Kusama Asset Hub and People chains#718muharem wants to merge 9 commits intopolkadot-fellows:mainfrom
muharem wants to merge 9 commits intopolkadot-fellows:mainfrom
Conversation
muharem
commented
May 7, 2025
s0me0ne-unkn0wn
approved these changes
May 7, 2025
Contributor
s0me0ne-unkn0wn
left a comment
s0me0ne-unkn0wn
left a comment
There was a problem hiding this comment.
Given that the NORMAL_DISPATCH_RATIO is 85% for this runtime, so we shouldn't overshoot even in the worst case, LGTM.
| pub const NORMAL_DISPATCH_RATIO: Perbill = Perbill::from_percent(85); | ||
|
|
||
| /// Maximum PoV size. | ||
| // TODO: This value is copied from the recent update of the `polkadot_primitives::MAX_POV_SIZE` |
Contributor
There was a problem hiding this comment.
Not sure it's recorded in the style guide, but generally a TODO item in comments requires a corresponding Github issue
muharem
changed the title
muharem
changed the title
joepetrowski
reviewed
May 7, 2025
|
|
||
| ### Changed | ||
|
|
||
| - Max PoV size 10mb for Kusama Asset Hub and People chains ([polkadot-fellows/runtimes/pull/718](https://github.com/polkadot-fellows/runtimes/pull/718)) |
Contributor
There was a problem hiding this comment.
Why only these chains?
muharem
changed the title
Contributor
Author
|
@s0me0ne-unkn0wn I have updated it for all System Parachains. please check this again |
s0me0ne-unkn0wn
approved these changes
May 7, 2025
This reverts commit 7b68801.
muharem
changed the title
Contributor
Author
|
I will open a new PR for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Max PoV size 10mb for Kusama Asset Hub and People chains.
The Kusama and Polkadot Relay Chains have recently increased their max PoV size to 10 MB. Parachain runtime configurations will be updated accordingly through the upcoming SDK release and its integration, which includes this PR: paritytech/polkadot-sdk#5884.
However, this update will not be available before the planned migration. In this PR, I propose updating the block size configuration for Asset Hub ahead of that SDK release to ensure the extra capacity is available for the migration.
This PR updates the proof size specifically for runtimes with async backing enabled (Asset Hub and People chains) to support the upcoming Asset Hub migration. Currently, only Asset Hub is updated - along with the People chain, as it shares constants from the async backing module - since this change is part of the ongoing migration effort.