proxy types: refactor whitelist of calls by gui1117 · Pull Request #646 · polkadot-fellows/runtimes

gui1117 · 2025-03-27T02:55:16Z

Simply refactor the whitelist of calls in proxy types.
Whitelist is a better practice than blacklist in this context.

bkchr

I would not add pallets to the whitelist that have no callable functions for users.

Also this pr requires a CHANGELOG entry.

bkchr · 2025-03-27T11:18:42Z

+					RuntimeCall::Aura(_) |
+					RuntimeCall::AuraExt(_) |
+					RuntimeCall::XcmpQueue(_) |
+					RuntimeCall::CumulusXcm(_) |
+					RuntimeCall::ToPolkadotXcmRouter(_) |
+					RuntimeCall::MessageQueue(_) |


There is no functionality for users.

Yes done: 10a4767

But I didn't look extremely carefully for each pallet but I think I didn't miss any.

bkchr · 2025-03-27T11:18:53Z

+					RuntimeCall::Multisig(_) |
+					RuntimeCall::Proxy(_) |
+					RuntimeCall::RemoteProxyRelayChain(_) |
+					RuntimeCall::StateTrieMigration(_)


Suggested change

RuntimeCall::StateTrieMigration(_)

bkchr · 2025-03-31T10:39:36Z

@gui1117 CI is not happy.

github-actions · 2025-03-31T11:40:11Z

Review required! Latest push from author must always be reviewed

gui1117 · 2025-04-01T04:06:58Z

Yes sorry fixed.

ecosystem tests seems hanging, I will look into it later.

EDIT: some timeout error, let's re-run

bkchr · 2025-04-15T21:00:12Z

+					RuntimeCall::Broker(pallet_broker::Call::claim_revenue { .. }) |
+					RuntimeCall::Broker(pallet_broker::Call::drop_region { .. }) |
+					RuntimeCall::Broker(pallet_broker::Call::drop_contribution { .. }) |
+					RuntimeCall::Broker(pallet_broker::Call::drop_history { .. }) |
+					RuntimeCall::Broker(pallet_broker::Call::drop_renewal { .. }) |


Besides this one, the other calls should not be required.

yes ok, partition could be added, but I kept it removed. done 48b9837

bkchr · 2025-04-15T21:00:28Z

+					RuntimeCall::Broker(pallet_broker::Call::set_lease { .. }) |
+					RuntimeCall::Broker(pallet_broker::Call::start_sales { .. }) |
+					RuntimeCall::Broker(pallet_broker::Call::partition { .. }) |
+					RuntimeCall::Broker(pallet_broker::Call::claim_revenue { .. }) |


yes done 48b9837

bkchr · 2025-04-15T21:01:45Z

+					RuntimeCall::EncointerScheduler(_) |
+					RuntimeCall::EncointerCeremonies(_) |
+					RuntimeCall::EncointerCommunities(_) |
+					RuntimeCall::EncointerBazaar(_) |
+					RuntimeCall::EncointerReputationCommitments(_) |
+					RuntimeCall::EncointerFaucet(_) |
+					RuntimeCall::EncointerDemocracy(_) |
+					RuntimeCall::EncointerTreasuries(_)


@clangenb could you verify these?

Yes. looks good to me!

Co-authored-by: Bastian Köcher <git@kchr.de>

clangenb · 2025-04-29T06:06:42Z

+					RuntimeCall::EncointerScheduler(_) |
+					RuntimeCall::EncointerCeremonies(_) |
+					RuntimeCall::EncointerCommunities(_) |
+					RuntimeCall::EncointerBazaar(_) |
+					RuntimeCall::EncointerReputationCommitments(_) |
+					RuntimeCall::EncointerFaucet(_) |
+					RuntimeCall::EncointerDemocracy(_) |
+					RuntimeCall::EncointerTreasuries(_)


Yes. looks good to me!

acatangiu · 2025-08-15T13:00:34Z

 - Disable MBM migrations for all runtimes for check-migrations CI ([polkadot-fellows/runtimes/pull/590](https://github.com/polkadot-fellows/runtimes/pull/590))
 - chain-spec-generator supports conditional building (`--no-default-features --features <runtime>` or `--no-default-features --features all-runtimes` or
  `--no-default-features --features all-polkadot` or `--no-default-features --features all-kusama`)([polkadot-fellows/runtimes/pull/637](https://github.com/polkadot-fellows/runtimes/pull/637))
+- Proxy type `NonTranfer`: Use a whitelist of calls and remove calls to pallets with not useful calls ([polkadot-fellows/runtimes/pull/646](https://github.com/polkadot-fellows/runtimes/pull/646))


please move this to its right place in the changelog (under "unreleased")

yes done: 81b6fb6

acatangiu · 2025-08-15T13:01:23Z

and please a more descriptive title/description for the PR 😄

acatangiu · 2025-08-18T09:35:30Z

/merge

fellowship-merge-bot · 2025-08-18T10:29:11Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

ggwpez · 2025-08-18T11:10:36Z

 		match self {
 			ProxyType::Any => true,
-			ProxyType::NonTransfer => !matches!(
+			ProxyType::NonTransfer => matches!(


This conflicts with the changes in the call filter of the asset hub migration... can we please pause doing refactors until AHM is done.

yes, you're right, sorry about that Oli!

gui1117 added 2 commits March 27, 2025 11:49

refactor

9d899da

fix

3db0410

bkchr reviewed Mar 27, 2025

View reviewed changes

gui1117 added 3 commits March 27, 2025 21:16

remove useless calls

10a4767

add back the comments

43f2ca7

changelog

3ed5409

gui1117 added 3 commits March 31, 2025 19:47

fix syntax error

34acd97

remove some more calls

5a2f571

fix all typo

c794e2e

fmt

d081166

Merge branch 'main' into gui-refactor

fb708ff

bkchr approved these changes Apr 15, 2025

View reviewed changes

Update CHANGELOG.md

5d370c2

Co-authored-by: Bastian Köcher <git@kchr.de>

github-actions Bot requested a review from bkchr April 16, 2025 01:06

gui1117 added 2 commits April 16, 2025 10:19

remove unnecessary calls

48b9837

fmt

8323baf

bkchr approved these changes Apr 28, 2025

View reviewed changes

bkchr requested a review from ggwpez April 28, 2025 19:54

clangenb approved these changes Apr 29, 2025

View reviewed changes

Merge branch 'main' into gui-refactor

0b28d09

acatangiu reviewed Aug 15, 2025

View reviewed changes

relocate in the changelog

81b6fb6

gui1117 changed the title ~~Refactor a bit~~ proxy types: refactor whitelist of calls Aug 18, 2025

gui1117 and others added 3 commits August 18, 2025 12:19

remove removed call from the whitelist

c8cd038

fix removal of removed call

1352ab6

Merge branch 'main' into gui-refactor

3a11842

acatangiu approved these changes Aug 18, 2025

View reviewed changes

fellowship-merge-bot Bot enabled auto-merge (squash) August 18, 2025 10:29

fellowship-merge-bot Bot merged commit 1759908 into polkadot-fellows:main Aug 18, 2025
52 of 62 checks passed

ggwpez reviewed Aug 18, 2025

View reviewed changes

Conversation

gui1117 commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkchr commented Mar 31, 2025

Uh oh!

github-actions Bot commented Mar 31, 2025

Uh oh!

gui1117 commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acatangiu commented Aug 15, 2025

Uh oh!

acatangiu commented Aug 18, 2025

Uh oh!

fellowship-merge-bot Bot commented Aug 18, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gui1117 commented Mar 27, 2025 •

edited

Loading

gui1117 commented Apr 1, 2025 •

edited

Loading