Update to stable2603#1114
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Found 5 correctness issues in the runtime upgrade changes. Review Suggestionssystem-parachains/coretime/coretime-kusama/src/coretime.rs:102 This new early system-parachains/coretime/coretime-polkadot/src/coretime.rs:102 This early relay/kusama/src/lib.rs:1557 Removing relay/polkadot/src/lib.rs:1340 This removes the explicit system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs:125 Most of the |
|
Found 5 correctness issues in the runtime upgrade changes. Review Suggestionssystem-parachains/coretime/coretime-kusama/src/coretime.rs:102 This now returns system-parachains/coretime/coretime-polkadot/src/coretime.rs:102 Same issue here: the early relay/kusama/src/lib.rs:1466, 1556, 2068 The runtime no longer wires in relay/polkadot/src/lib.rs:1249, 1339, 1861 The Polkadot runtime has the same coretime assignment regression: the dedicated assignment provider pallet was removed and replaced with TODO comments, while chain-spec-generator/src/common.rs:29, 68-69 Support for |
|
Hey @ggwpez do you have any timeline/plan/idea, when we want to merge an release this? (Just asking, because of other planning) |
2603 is not out yet, but once its out I would try to get this merged within 2 weeks (hopefully earlier). What exactly are you depending on? Can also DM me. |
|
Found 3 correctness issues in the runtime upgrade changes. Review Suggestionsrelay/kusama/src/lib.rs:1556, 2068 The relay/polkadot/src/lib.rs:1339, 1861 The coretime assignment provider was effectively dropped here by removing both system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs:125 Setting |
|
Can we remove the AHM-related code from runtimes (different PR) to simplify things? |
|
One useful "SDK bump integration step" is to have Claude compare the runtimes config update against the Westend runtimes configurations on the respective SDK release branch. Maybe even create a skill describing (automating) the manual process we're currently doing (1. bump deps, 2. git diff for new configs, 3. git blame sdk, 4. check sdk PR, 5. adapt runtime config here with same/similar logic). L.E.: this comment should've been a new issue actually, sorry 🙈 |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Found 3 correctness issues in the runtime update: two relay runtimes drop the coretime assignment provider wiring, and the new Bridge Hub Polkadot inbound queue v2 config disables message processing. Review Suggestionsrelay/kusama/src/lib.rs:1556, 2068 The relay/polkadot/src/lib.rs:1339, 1861 This mirrors the Kusama issue: system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs:125 Setting |
There was a problem hiding this comment.
Found 3 correctness issues in the runtime upgrade changes.
Suggestions that couldn't be attached to a specific line
relay/kusama/src/lib.rs:1556
The parachains_scheduler::Config implementation no longer sets type AssignmentProvider, and the CoretimeAssignmentProvider pallet was also removed from the runtime. This is not just a refactor of names: it changes how scheduler assignments are sourced for parachains while parachains_paras::Config was simultaneously switched to ParaScheduler on line 1466. If stable2603 expects an explicit assignment provider here, leaving it unset changes runtime behavior and can break coretime/on-demand scheduling semantics or storage compatibility. Wire the new provider explicitly according to the SDK migration instead of leaving a TODO in the runtime.
system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs:125
Replacing the entire inbound-queue-v2 processing stack with type MessageProcessor = (); drops the previously configured XCM sender, executor, message converter, and account/location mapping. Unless () is a fully functional processor in this SDK version, inbound Ethereum messages will be accepted but never translated/executed, effectively disabling bridge delivery. Hook this config up to the concrete message processor required by snowbridge_pallet_inbound_queue_v2 instead of leaving the runtime with a placeholder.
Yes, I can try to merge that in advance. |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Found 4 correctness issues in the runtime and chain spec changes. Review Suggestionsrelay/kusama/src/lib.rs:1559, 2071 The scheduler's relay/polkadot/src/lib.rs:1342, 1864 This has the same issue as Kusama: the dedicated system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs:124
chain-spec-generator/src/common.rs:29, 68-69 Support for |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
## Summary Update the `BountyDepositBase` parameter for `pallet_bounties` on both Asset Hub Polkadot and Asset Hub Kusama to use explicit currency values that better reflect the economic significance of a bounty proposal. - **Asset Hub Polkadot:** `system_para_deposit(0, 176)` -> `10 * DOLLARS` (10 DOT) - **Asset Hub Kusama:** `system_para_deposit(0, 176)` -> `10 * QUID` (~0.33 KSM) ## Motivation The previous deposit was derived from `system_para_deposit(0, 176)`, which only accounted for byte-level storage cost and passed `0` for the `items` parameter. Since bounty proposals are significant governance actions that request treasury funds, the deposit should reflect that weight -- similar to how `SubmissionDeposit` for referenda is set to a meaningful fixed value (10 DOT) rather than being purely storage-derived. Setting `BountyDepositBase` to a fixed value aligns with the pattern used by other governance deposits on Asset Hub and ensures the deposit is proportional to the action being taken. The deposit is fully returned to the proposer when the bounty is approved, so legitimate users are not penalized. ## Context - Bounty proposals are permissionless -- any signed account can submit them. - The deposit is slashable on rejection (`close_bounty` by `RejectOrigin` slashes the bond into Treasury). - The deposit is returned in full when the bounty is approved and funded. - Other governance deposits on Asset Hub use fixed values (e.g., `SubmissionDeposit = 10 * DOLLARS` for referenda), so this change follows the same convention.
|
Found 2 issues in the runtime and test changes. Review Suggestionsrelay/polkadot/src/xcm_config.rs:214,220 The new waived-fee origin is built from integration-tests/emulated/tests/assets/asset-hub-polkadot/src/tests/teleport.rs:827,841 These teleport tests are now ignored instead of being updated to the new SDK accounting semantics. Because the PR explicitly changes teleport behavior and mentions teleport regressions, removing these assertions from CI drops coverage for exactly the area most likely to break and can let issuance/accounting bugs ship unnoticed. Update the assertions to the new fee calculation model (or narrow the checked invariants if total issuance is no longer stable) rather than blanket-ignoring the tests. |
|
FYI: I am currently investigating all the failing and ignored tests following the SDK upgrade - have fixed most, still struggling with some weird bridge failures |
|
ignored tests fixed here: #1136 |
A bunch of fixes. - [x] Does not require a CHANGELOG entry
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Found 2 correctness issues in the Asset Hub bounty sweeping changes. Review Suggestionssystem-parachains/asset-hubs/asset-hub-polkadot/src/treasury.rs:67-93 The new system-parachains/asset-hubs/asset-hub-kusama/src/treasury.rs:126-140 The Kusama |
|
Found 1 issue in the Asset Hub bounty sweep changes. Review Suggestionssystem-parachains/asset-hubs/asset-hub-polkadot/src/treasury.rs:66-93 The new |
Pallet is disabled on the relays anyway. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
…sury test to use AH treasury Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This comment was marked as duplicate.
This comment was marked as duplicate.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This comment was marked as duplicate.
This comment was marked as duplicate.
claravanstaden
left a comment
There was a problem hiding this comment.
Looks good! @acatangiu I see you increased the Snowbridge EXECUTION_IN_ETHER in the tests considerably, which made me a bit worried. But I see the actual increase required is closer to 23x than the 8x you increased it to, which is okay I guess, because it is a test. I've made a mental note XCM execution cost increases in this runtime.
|
/merge |
|
Enabled Available commands
For more information see the documentation |
Updates all runtimes to Polkadot SDK stable2603. Weights to be updated in a follow up.
Added
ParachainHostruntime API to v16max_relay_parent_session_agewith0(to be configured via governance)Changed
TransferAllAssetsonpallet_bountiesto sweep fungibles from closed bounty accountsRemoved
CoretimeAssignmentProviderpalletMigration Check Failures
The remaining failing try-runtime checks for KAH and PAH are from the assets pallet and are caused by bad historic state.
PAH triggers here since there are some accounts with the historic USDT ED of 0.1 instead of 1 cent.
KAH triggers a failure here but I did not check why, we newly added this check for 2603.
Tests
I had to tweak a lot of tests and ignore some. Please sanity check it, we can delete the ignored ones afterwards.done