Add multi asset bounties to runtime and upgrade related deps#1070
Conversation
|
@pandres95 FYI |
20b74ae to
2404b1c
Compare
|
/cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties |
|
Sorry, only fellows can run commands. |
|
/cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties |
|
Easier to review probably looking at the diff here: sigurpol/runtimes@sigurpol-release-2_0_6...dhirajs0:runtimes:dhiraj-add-multi-asset-bounties-and-upgrade-deps |
|
Here is the PR against sigurpol:sigurpol-release-2_0_6 branch for easier review |
|
Hi @ggwpez , can you please run the below bench, I don't have access 🥲. |
|
/cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties |
|
Command "" has started 🚀 See logs here |
|
Command "" has finished ✅ See logs here |
@muharem , @dhirajs0 unfortunately multi-line /cmd bench are not supported, because of the way the regex works in the cmd bench yml. I have discovered it recently as well see #1065 (comment) 😅 |
|
Thanks for triggering those /cmd bench, @muharem. Just a heads-up that according to the comment from Paolo, the runner doesn't support multi-line commands. You might need to post them individually for the CI to start. |
|
Hi @pandres95! This is the same branch you reviewed here. The only new addition is the changelog commit, so this should be a nice, quick 'drive-by' review for you! |
|
@dhirajs0 the error in migration jobs is not concerning, just a temporary CI issue, they all fail in |
Thanks for the update!🙇♂️ I was wondering why these CI jobs are failing now as earlier they were passing. |
|
Review required! Latest push from author must always be reviewed |
|
/merge |
Auto-Merge-BotUser @sigurpol is not the author of the PR and does not publicly belong to the org Only author or public org members can trigger the bot. |
|
/merge |
|
Enabled Available commands
For more information see the documentation |
Failed to update PR ❌There was an error while trying to keep this PR You may have conflicts More info in the logs 📋 |
1c6a06a
into
polkadot-fellows:main
Summary
This PR adds multi-asset bounties support to asset hub runtime and Remove local pay module in favor of upstream implementation
Changes
Features
pallet-multi-asset-bounties v0.2.1to Kusama Asset Hubpallet-multi-asset-bounties v0.2.1to Polkadot Asset HubTODO:
run benchmarks : Please run the below benchmarks 🙏 separately as multi /cmd bench are not supported.
` /cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties
/cmd bench --runtime asset-hub-polkadot --pallet pallet_multi_asset_bounties
`