Skip to content

Add multi asset bounties to runtime and upgrade related deps#1070

Merged
fellowship-merge-bot[bot] merged 21 commits into
polkadot-fellows:mainfrom
dhirajs0:dhiraj-add-multi-asset-bounties-and-upgrade-deps
Feb 24, 2026
Merged

Add multi asset bounties to runtime and upgrade related deps#1070
fellowship-merge-bot[bot] merged 21 commits into
polkadot-fellows:mainfrom
dhirajs0:dhiraj-add-multi-asset-bounties-and-upgrade-deps

Conversation

@dhirajs0

@dhirajs0 dhirajs0 commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds multi-asset bounties support to asset hub runtime and Remove local pay module in favor of upstream implementation

Changes

Features

TODO:

  • run benchmarks : Please run the below benchmarks 🙏 separately as multi /cmd bench are not supported.
    ` /cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties

    /cmd bench --runtime asset-hub-polkadot --pallet pallet_multi_asset_bounties
    `

@sigurpol

sigurpol commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

@pandres95 FYI

@sigurpol sigurpol mentioned this pull request Feb 6, 2026
2 tasks
@dhirajs0 dhirajs0 force-pushed the dhiraj-add-multi-asset-bounties-and-upgrade-deps branch from 20b74ae to 2404b1c Compare February 6, 2026 12:33
@dhirajs0

dhirajs0 commented Feb 6, 2026

Copy link
Copy Markdown
Contributor Author

/cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties

@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown

Sorry, only fellows can run commands.

@ggwpez

ggwpez commented Feb 6, 2026

Copy link
Copy Markdown
Member

/cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties

@sigurpol

sigurpol commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

@dhirajs0

dhirajs0 commented Feb 6, 2026

Copy link
Copy Markdown
Contributor Author

Here is the PR against sigurpol:sigurpol-release-2_0_6 branch for easier review
sigurpol#4

@dhirajs0

Copy link
Copy Markdown
Contributor Author

Hi @ggwpez , can you please run the below bench, I don't have access 🥲.
/cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties
/cmd bench --runtime asset-hub-polkadot --pallet pallet_multi_asset_bounties

@muharem

muharem commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

/cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties
/cmd bench --runtime asset-hub-polkadot --pallet pallet_multi_asset_bounties

@github-actions

Copy link
Copy Markdown

Command "" has started 🚀 See logs here

@github-actions

Copy link
Copy Markdown

Command "" has finished ✅ See logs here

@sigurpol

sigurpol commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

/cmd bench --runtime asset-hub-kusama --pallet pallet_multi_asset_bounties /cmd bench --runtime asset-hub-polkadot --pallet pallet_multi_asset_bounties

@muharem , @dhirajs0 unfortunately multi-line /cmd bench are not supported, because of the way the regex works in the cmd bench yml. I have discovered it recently as well see #1065 (comment) 😅

@dhirajs0

Copy link
Copy Markdown
Contributor Author

Thanks for triggering those /cmd bench, @muharem. Just a heads-up that according to the comment from Paolo, the runner doesn't support multi-line commands. You might need to post them individually for the CI to start.

@dhirajs0

Copy link
Copy Markdown
Contributor Author

Hi @pandres95! This is the same branch you reviewed here. The only new addition is the changelog commit, so this should be a nice, quick 'drive-by' review for you!

@sigurpol

Copy link
Copy Markdown
Contributor

@dhirajs0 the error in migration jobs is not concerning, just a temporary CI issue, they all fail in
Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: try-runtime-snapshot-polkadot-
not your PR issue - we saw it happening already even while testing #1065 and shouldn't prevent this PR to get merged quickly once it gets another approval. We will run migrations again before 2.1.0 final PR in any case.

@dhirajs0

dhirajs0 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

@dhirajs0 the error in migration jobs is not concerning, just a temporary CI issue, they all fail in Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: try-runtime-snapshot-polkadot- not your PR issue - we saw it happening already even while testing #1065 and shouldn't prevent this PR to get merged quickly once it gets another approval. We will run migrations again before 2.1.0 final PR in any case.

Thanks for the update!🙇‍♂️ I was wondering why these CI jobs are failing now as earlier they were passing.

@github-actions github-actions Bot requested review from ggwpez and muharem February 23, 2026 15:03
@github-actions

Copy link
Copy Markdown

Review required! Latest push from author must always be reviewed

@dhirajs0

dhirajs0 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review @muharem @ggwpez ! 🙇‍♂️
A re-approval is triggered after I updated branch with merge commit😅

@sigurpol

Copy link
Copy Markdown
Contributor

Thanks for the review @muharem @ggwpez ! 🙇‍♂️ A re-approval is triggered after I updated branch with merge commit😅

the good (?) news is that at least you just need a single approval now 😅 Getting closer and closer 😄

@sigurpol

Copy link
Copy Markdown
Contributor

/merge

@fellowship-merge-bot

Copy link
Copy Markdown
Contributor

Auto-Merge-Bot

User @sigurpol is not the author of the PR and does not publicly belong to the org polkadot-fellows.

Only author or public org members can trigger the bot.

@dhirajs0

Copy link
Copy Markdown
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot Bot enabled auto-merge (squash) February 24, 2026 11:11
@fellowship-merge-bot

Copy link
Copy Markdown
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot

Copy link
Copy Markdown
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot fellowship-merge-bot Bot merged commit 1c6a06a into polkadot-fellows:main Feb 24, 2026
80 of 94 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Runtime releases Feb 24, 2026
@ggwpez ggwpez mentioned this pull request Feb 24, 2026
1 task
fellowship-merge-bot Bot pushed a commit that referenced this pull request Mar 9, 2026
Changes:
- Bump specs to 2.1.0
- Backport 2.0.6 CHANGELOG entry
- Publish 2.1.0

Depends on:
- #1070
- #1085
- #1082
- #1042
- #1098
- #1097
- [x] Resolve TODOs

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove the pay module local implementation and use the upstream/polkadot-sdk version when available.

6 participants