Add storage-weight-reclaim to polkadot system chains#1047
Conversation
|
/cmd bench --runtime asset-hub-polkadot bridge-hub-polkadot coretime-polkadot collectives-polkadot people-polkadot --pallet cumulus_pallet_weight_reclaim |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Command "bench --runtime asset-hub-polkadot bridge-hub-polkadot coretime-polkadot collectives-polkadot people-polkadot --pallet cumulus_pallet_weight_reclaim" has started 🚀 See logs here |
…ot bridge-hub-polkadot coretime-polkadot collectives-polkadot people-polkadot --pallet cumulus_pallet_weight_reclaim'
|
Command "bench --runtime asset-hub-polkadot bridge-hub-polkadot coretime-polkadot collectives-polkadot people-polkadot --pallet cumulus_pallet_weight_reclaim" has finished ✅ See logs here DetailsSubweight results:
|
|
/cmd bench --runtime asset-hub-polkadot --pallet cumulus_pallet_weight_reclaim |
|
Command "bench --runtime asset-hub-polkadot --pallet cumulus_pallet_weight_reclaim" has started 🚀 See logs here |
…ot --pallet cumulus_pallet_weight_reclaim'
|
Command "bench --runtime asset-hub-polkadot --pallet cumulus_pallet_weight_reclaim" has finished ✅ See logs here DetailsSubweight results:
|
There was a problem hiding this comment.
Found 2 cross-cutting correctness/maintainability risks in the new StorageWeightReclaim TransactionExtension wiring: (1) potential ordering/fee-impact ambiguity depending on how the wrapper sequences post_dispatch relative to fee-charging extensions, and (2) tests now rely on implicit .into() conversions that make the signed-extra composition less explicit and easier to break with future extension changes.
…1049) While working on #1047 I noticed that the `/cmd bench` command commits `solc` and `resolc` binaries. This is unwanted. I propose to not put the binaries into the main repo directory, but use the `RUNNER_TEMP` directory. Then we have a general solution and don't need to mess with manual exclusion of whatever tooling we want in the future in the git workflow. Example commit created by bot which shows the issue: 1854d62 Example commit which shows that fix works (no binaries present): a4e34df - [x] Does not require a CHANGELOG entry Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
|
Review required! Latest push from author must always be reviewed |
There was a problem hiding this comment.
Found several whitespace-only line additions (likely trailing whitespace) across the new runtime/weights files, and a changelog entry that should include the PR reference for traceability.
Suggestions that couldn't be attached to a specific line
system-parachains/asset-hubs/asset-hub-polkadot/src/weights/cumulus_pallet_weight_reclaim.rs:4,16,24,39,44
The newly added auto-generated weights file includes whitespace-only lines (blank lines containing spaces). Strip whitespace on empty lines to prevent whitespace-sensitive CI/lint failures and reduce noisy diffs.
system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights/cumulus_pallet_weight_reclaim.rs:4,16,24,39,44
The newly added auto-generated weights file includes whitespace-only lines (blank lines containing spaces). Strip whitespace on empty lines to prevent whitespace-sensitive CI/lint failures and reduce noisy diffs.
system-parachains/collectives/collectives-polkadot/src/weights/cumulus_pallet_weight_reclaim.rs:4,16,24,39,44
The newly added auto-generated weights file includes whitespace-only lines (blank lines containing spaces). Strip whitespace on empty lines to prevent whitespace-sensitive CI/lint failures and reduce noisy diffs.
system-parachains/coretime/coretime-polkadot/src/weights/cumulus_pallet_weight_reclaim.rs:4,16,24,39,44
The newly added auto-generated weights file includes whitespace-only lines (blank lines containing spaces). Strip whitespace on empty lines to prevent whitespace-sensitive CI/lint failures and reduce noisy diffs.
system-parachains/people/people-polkadot/src/weights/cumulus_pallet_weight_reclaim.rs:4,16,24,39,44
The newly added auto-generated weights file includes whitespace-only lines (blank lines containing spaces). Strip whitespace on empty lines to prevent whitespace-sensitive CI/lint failures and reduce noisy diffs.
|
|
||
| ### Added | ||
| - AH Polkadot - A new stepped curve primitive. Used for the 'Hard Pressure' inflation changes from [Ref 1710](https://polkadot.subsquare.io/referenda/1710) ([#898](https://github.com/polkadot-fellows/runtimes/pull/898)). | ||
| - Add `cumulus-pallet-weight-reclaim` to all Polkadot system parachains (Asset Hub, Bridge Hub, Coretime, People, Collectives) for storage weight reclaim functionality. |
There was a problem hiding this comment.
Changelog entry lacks a PR/link reference and ends without a consistent style/format compared to surrounding bullets. Add the PR number/link (and keep punctuation consistent) to make the change traceable (e.g., "... functionality. (#NNNN)").
| impl cumulus_pallet_weight_reclaim::Config for Runtime { | ||
| type WeightInfo = weights::cumulus_pallet_weight_reclaim::WeightInfo<Runtime>; | ||
| } | ||
|
|
There was a problem hiding this comment.
A whitespace-only line was added (diff shows a standalone added line). Remove trailing whitespace/blank lines containing spaces to avoid formatting/CI checks that fail on whitespace-only changes.
| impl cumulus_pallet_weight_reclaim::Config for Runtime { | ||
| type WeightInfo = weights::cumulus_pallet_weight_reclaim::WeightInfo<Runtime>; | ||
| } | ||
|
|
There was a problem hiding this comment.
A whitespace-only line was added (diff shows a standalone added line). Remove trailing whitespace/blank lines containing spaces to avoid formatting/CI checks that fail on whitespace-only changes.
| impl cumulus_pallet_weight_reclaim::Config for Runtime { | ||
| type WeightInfo = weights::cumulus_pallet_weight_reclaim::WeightInfo<Runtime>; | ||
| } | ||
|
|
There was a problem hiding this comment.
A whitespace-only line was added (diff shows a standalone added line). Remove trailing whitespace/blank lines containing spaces to avoid formatting/CI checks that fail on whitespace-only changes.
| impl cumulus_pallet_weight_reclaim::Config for Runtime { | ||
| type WeightInfo = weights::cumulus_pallet_weight_reclaim::WeightInfo<Runtime>; | ||
| } | ||
|
|
There was a problem hiding this comment.
A whitespace-only line was added (diff shows a standalone added line). Remove trailing whitespace/blank lines containing spaces to avoid formatting/CI checks that fail on whitespace-only changes.
| impl cumulus_pallet_weight_reclaim::Config for Runtime { | ||
| type WeightInfo = weights::cumulus_pallet_weight_reclaim::WeightInfo<Runtime>; | ||
| } | ||
|
|
There was a problem hiding this comment.
A whitespace-only line was added (diff shows a standalone added line). Remove trailing whitespace/blank lines containing spaces to avoid formatting/CI checks that fail on whitespace-only changes.
# Conflicts: # CHANGELOG.md # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/lib.rs
|
/cmd fmt |
|
Command "fmt" has started 🚀 See logs here |
|
Command "fmt" has finished ✅ See logs here |
|
/merge |
There was a problem running the action.❌😵❌ Please find more information in the logs. |
6 participants
This adds storage-weight-reclaim to polkadot-system-chains.