Upgrade to unstable2507 by TorstenStueber · Pull Request #1029 · polkadot-fellows/runtimes

TorstenStueber · 2025-12-10T08:32:15Z

This upgrades polkadot-sdk crates to the latest version of unstable2507. The main change is the following backport: paritytech/polkadot-sdk#10552.

This is an important step for upgrading the Kusama AH runtime to the latest version of pallet-revive with:

EVM backend
Ethereum block storage
New gas mapping

…times

TorstenStueber · 2025-12-10T08:34:41Z


 impl pallet_transaction_payment::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
-	type OnChargeTransaction = impls::tx_payment::FungiblesAdapter<


Reasoning for this change: Using FungiblesAdapter (plural) for NativeAndAsset and DotLocation is the same as using FungibleAdapter (singular) with Balances because NativeAndAsset will just forward all calls to Balances for DotLocation.

ggwpez · 2025-12-10T11:09:38Z

-pallet-election-provider-multi-block = { version = "0.3.4", default-features = false }
-pallet-staking-async = { version = "0.6.2", default-features = false }
+pallet-election-provider-multi-block = { version = "0.5.0", default-features = false }
+pallet-staking-async = { version = "0.7.0", default-features = false }


@kianenigma anything to do when bumping these?

No changes needed for this bump.

ggwpez · 2025-12-10T11:16:57Z

 	type OnChargeTransaction =
 		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<StakingPot, Balances>>;
-	type WeightToFee = WeightToFee;
+	type WeightToFee = pallet_revive::evm::fees::BlockRatioFee<333333333, 10_815_700_000_000, Self>;


Where do these numbers come from?

This encodes the same fraction as the one in the WeightToFeePolynomial used in WeightToFee, which is defined as:

numerator: super::currency::CENTS

this is 1_000_000_000_000 / 30 / 100 = 333_333_333

denominator: 100 * Balance::from(ExtrinsicBaseWeight::get().ref_time())

this is 100 * 1_000 * 108_157 = 10_815_700_000

I corrected the value that was here before, it was wrongly calculated.

Maybe you can add a sanity check test to ensure that the fee of a simple transaction is sane?
And please put the calculation into a comment above the code so that we can reproduce it later.

I added a comment with explanation.

athei · 2025-12-10T18:02:11Z

/cmd bench --runtime asset-hub-kusama --pallet pallet_revive

github-actions · 2025-12-10T19:05:03Z

Command "bench --runtime asset-hub-kusama --pallet pallet_revive" has started 🚀 See logs here

github-actions · 2025-12-10T19:13:43Z

Command "bench --runtime asset-hub-kusama --pallet pallet_revive" has finished ✅ See logs here

Details

Subweight results:

No changes found.

…times

athei · 2025-12-11T12:20:21Z

/cmd fmt

acatangiu · 2025-12-11T13:09:56Z

 	type OnChargeTransaction =
 		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<StakingPot, Balances>>;
-	type WeightToFee = WeightToFee;
+	type WeightToFee = pallet_revive::evm::fees::BlockRatioFee<333333333, 10_815_700_000, Self>;


can you add a comment here explaining the used WeightToFee? I'm sure it will not age well without clear docs/code-comments..

I added a comment with explanation.

acatangiu · 2025-12-11T13:12:19Z

+	type DepositPerChildTrieItem = DepositPerChildTrieItem;
 	type DepositPerByte = DepositPerByte;
-	type WeightPrice = pallet_transaction_payment::Pallet<Self>;
 	// TODO(#840): use `weights::pallet_revive::WeightInfo` here


with the new pallet-revive version you should be able to fix this too, right?

I believe the benchmark is still not fixed. Also we need solc to be installed on the benchmarking bot. We don't have time to get this done right now.

acatangiu · 2025-12-11T13:21:21Z

+snowbridge-outbound-queue-runtime-api = { version = "0.17.0", default-features = false }
+snowbridge-outbound-queue-v2-runtime-api = { version = "0.6.0", default-features = false }
+snowbridge-outbound-queue-primitives = { version = "0.6.0", default-features = false }
+snowbridge-pallet-ethereum-client = { version = "0.17.0", default-features = false }
+snowbridge-pallet-inbound-queue = { version = "0.17.0", default-features = false }
+snowbridge-pallet-inbound-queue-v2 = { version = "0.6.0", default-features = false }
+snowbridge-pallet-inbound-queue-fixtures = { version = "0.25.0" }
+snowbridge-pallet-ethereum-client-fixtures = { version = "0.25.0" }
+snowbridge-pallet-outbound-queue = { version = "0.17.0", default-features = false }
+snowbridge-pallet-outbound-queue-v2 = { version = "0.6.0", default-features = false }
+snowbridge-pallet-system = { version = "0.17.0", default-features = false }
+snowbridge-pallet-system-v2 = { version = "0.6.0", default-features = false }
+snowbridge-pallet-system-frontend = { version = "0.6.0", default-features = false }
+snowbridge-inbound-queue-primitives = { version = "0.6.0", default-features = false }
+snowbridge-runtime-common = { version = "0.18.0", default-features = false }
+snowbridge-runtime-test-common = { version = "0.20.0" }
+snowbridge-system-runtime-api = { version = "0.17.0", default-features = false }
+snowbridge-system-v2-runtime-api = { version = "0.6.0", default-features = false }


@claravanstaden please confirm the snowbridge pallet versions bump

All of the version bumps are just because of crate dependency changes.

github-actions · 2025-12-11T14:26:16Z

Command "fmt" has started 🚀 See logs here

github-actions · 2025-12-11T14:27:09Z

Command "fmt" has failed ❌! See logs here

claravanstaden

To bump to the latest: https://matrix.to/#/!cqAmzdIcbOFwrdrubV:parity.io/$Kygjlcxk58wiMVkbVeiK1mAfZtLnkB8i-oVBPnoIb5I?via=parity.io&via=matrix.org&via=web3.foundation

The other Snowbridge crate bumps are correct, its just because the Snowbridge crate dependency updates.

…times

TorstenStueber · 2025-12-12T11:43:56Z

To bump to the latest: https://matrix.to/#/!cqAmzdIcbOFwrdrubV:parity.io/$Kygjlcxk58wiMVkbVeiK1mAfZtLnkB8i-oVBPnoIb5I?via=parity.io&via=matrix.org&via=web3.foundation

The other Snowbridge crate bumps are correct, its just because the Snowbridge crate dependency updates.

I bumped that crate.

Prefund Ethereum style testnet accounts

…times

athei · 2025-12-16T14:24:40Z

The failures for kusama are actually real. We are missing this migration:
https://paritytech.github.io/polkadot-sdk/master/pallet_revive/migrations/v2/struct.Migration.html

Needs to be added to the pallet_migrations::Config:Migrations tuple.

acatangiu · 2025-12-17T11:18:47Z

@athei @TorstenStueber the asset-hub-kusama check-migrations is still failing for pallet-revive 😢

athei · 2025-12-17T14:44:29Z

Should be fixed by paritytech/polkadot-sdk#10680

TorstenStueber added 2 commits December 10, 2025 05:25

Update crates to unstable2507

4d07c65

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

5137407

…times

TorstenStueber commented Dec 10, 2025

View reviewed changes

ggwpez reviewed Dec 10, 2025

View reviewed changes

athei reviewed Dec 10, 2025

View reviewed changes

TorstenStueber added 3 commits December 10, 2025 18:08

Add PR feedback

e931c2e

Correct the WeightToFee multiplier

79d5244

Disable fixture compilation for clippy

78f1882

Ank4n mentioned this pull request Dec 11, 2025

[unstable2507] Backport #10311: [Staking] Async Election and Export paritytech/polkadot-sdk#10526

Merged

TorstenStueber added 3 commits December 11, 2025 07:55

Merge branch 'main' into main

43e1bb4

Fix CI

82c8b76

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

7871e45

…times

Fix fmt and change config values

11e5bed

acatangiu approved these changes Dec 11, 2025

View reviewed changes

ggwpez approved these changes Dec 11, 2025

View reviewed changes

athei approved these changes Dec 11, 2025

View reviewed changes

al3mart mentioned this pull request Dec 11, 2025

release: v1.19.3 paseo-network/passet-hub#33

Merged

claravanstaden reviewed Dec 11, 2025

View reviewed changes

Comment thread Cargo.toml Outdated

claravanstaden and others added 4 commits December 12, 2025 10:23

Update Cargo.toml

18a091f

Merge branch 'main' into main

85ca8d8

Upgrade snowbridge crates

f7cb372

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

46fb585

…times

TorstenStueber added 14 commits December 14, 2025 11:06

Merge pull request #1 from polkadot-fellows/at/prefunded

dc700e1

Prefund Ethereum style testnet accounts

Fix CI: install solc

33d2097

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

e07ddab

…times

Merge branch 'main' into main

d8753fa

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

b2f7cc4

…times

Fix CI: install solc (2)

1bd51f0

Fix CI: install solc (3)

0711843

Fix CI: install solc (4)

afa359e

Fix CI: install solc (5)

35058fb

Fix CI: install solc (6)

0132418

Empty commit

fb2f738

Empty commit (2)

8779939

Fix CI: install solc (7)

479c70f

Empty commit (3)

272da1f

athei approved these changes Dec 16, 2025

View reviewed changes

kapetan3sid mentioned this pull request Dec 16, 2025

Update “Connect to Polkadot Hub” page polkadot-developers/polkadot-docs#1224

Closed

claravanstaden approved these changes Dec 16, 2025

View reviewed changes

Fix pallet-revive migration

04b2eeb

github-actions Bot requested review from athei and claravanstaden December 16, 2025 14:49

acatangiu approved these changes Dec 17, 2025

View reviewed changes

lexnv approved these changes Dec 17, 2025

View reviewed changes

Bump pallet-revive

1bfa655

github-actions Bot requested a review from acatangiu December 17, 2025 17:43

Merge branch 'main' into main

270425c

bkchr approved these changes Dec 17, 2025

View reviewed changes

bkchr merged commit f56d87d into polkadot-fellows:main Dec 17, 2025
60 of 64 checks passed

Conversation

TorstenStueber commented Dec 10, 2025

Uh oh!

TorstenStueber Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorstenStueber Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggwpez Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

athei commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 10, 2025

Uh oh!

github-actions Bot commented Dec 10, 2025

Uh oh!

athei commented Dec 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 11, 2025

Uh oh!

github-actions Bot commented Dec 11, 2025

Uh oh!

claravanstaden left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TorstenStueber commented Dec 12, 2025

Uh oh!

athei commented Dec 16, 2025

Uh oh!

acatangiu commented Dec 17, 2025

Uh oh!

athei commented Dec 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

TorstenStueber Dec 10, 2025 •

edited

Loading

TorstenStueber Dec 11, 2025 •

edited

Loading

ggwpez Dec 11, 2025 •

edited

Loading

claravanstaden left a comment •

edited

Loading