[AHM] Remove migrator pallets (mostly)#1016
Merged
Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
approved these changes
Nov 25, 2025
| /// Unreleased migrations. Add new ones here: | ||
| pub type Unreleased = (); | ||
| pub type Unreleased = ( | ||
| frame_support::migrations::RemovePallet< |
Contributor
There was a problem hiding this comment.
How many storage items are these?
Member
Author
There was a problem hiding this comment.
Checking on PAH and KAH is similar. Very small footprint:
139 B AhMigrator
├ 36 B MigrationStartBlock
├ 36 B MigrationEndBlock
├ 34 B Unknown
└ 33 B AhMigrationStage
acatangiu
approved these changes
Nov 26, 2025
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2 tasks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
muharem
approved these changes
Mar 31, 2026
| Crowdloan(..) => false, | ||
|
|
||
| // Coretime: request_revenue_at is allowed, rest handled by catch-all. | ||
| Coretime(coretime::Call::<Runtime>::request_revenue_at { .. }) => true, |
Contributor
There was a problem hiding this comment.
interesting, why separate arm for this?
Member
Author
There was a problem hiding this comment.
Just to make it easier to see. No good reason.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
sigurpol
approved these changes
Apr 1, 2026
Contributor
sigurpol
left a comment
There was a problem hiding this comment.
LGTM (staking & friends - wise)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
acatangiu
approved these changes
Apr 1, 2026
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Review required! Latest push from author must always be reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
AssetHubMigrationApi::MigrationStartBlock()(andEndresp.). This is needed for indexers.TODO:
Remaining RC storage until final pallet cleanup: