Skip to content

[AHM] Remove migrator pallets (mostly)#1016

Merged
ggwpez merged 63 commits into
mainfrom
oty-ahm-cleanup
Apr 1, 2026
Merged

[AHM] Remove migrator pallets (mostly)#1016
ggwpez merged 63 commits into
mainfrom
oty-ahm-cleanup

Conversation

@ggwpez
Copy link
Copy Markdown
Member

@ggwpez ggwpez commented Nov 21, 2025

Changes:

  • Undeploy AH Migrator pallet
  • Delete 99% code of RC migrator pallet. Only thing kept is storage definition for posterior investigation.
  • Add Runtime API for accessing the migration start and end block. Both on RC and AH: AssetHubMigrationApi::MigrationStartBlock() (and End resp.). This is needed for indexers.

TODO:

  • Remove AH pallet storage

Remaining RC storage until final pallet cleanup:

52 K RcMigrator (647 keys, key: 46 K, value: 5.53 K, compressed: 1.86 K)
├── 36 K PureProxyCandidatesMigrated (498 keys, key: 36 K, compressed_key: 1.22 K, value: 498 B, compressed_value: 75 B)
├── 14 K RcAccounts (133 keys, key: 9.58 K, compressed_key: 405 B, value: 4.88 K, compressed_value: 113 B)
├── 168 B ManagerVotesInCurrentRound (2 keys, key: 160 B, compressed_key: 89 B, value: 8, compressed_value: 8)
├── 160 B ManagerMultisigs (2 keys, key: 94 B, compressed_key: 54 B, value: 66 B, compressed_value: 40 B)
├── 64 B RcMigratedBalanceArchive (1 keys, key: 32 B, compressed_key: 39 B, value: 32 B, compressed_value: 23 B)
├── 38 B Settings (1 keys, key: 32 B, compressed_key: 39 B, value: 6, compressed_value: 10 B)
├── 37 B WarmUpPeriod (1 keys, key: 32 B, compressed_key: 39 B, value: 5, compressed_value: 9)
├── 37 B CoolOffPeriod (1 keys, key: 32 B, compressed_key: 39 B, value: 5, compressed_value: 9)
├── 36 B UnprocessedMsgBuffer (1 keys, key: 32 B, compressed_key: 39 B, value: 4, compressed_value: 8)
├── 36 B MigrationStartBlock (1 keys, key: 32 B, compressed_key: 39 B, value: 4, compressed_value: 8)
├── 36 B MigrationEndBlock (1 keys, key: 32 B, compressed_key: 39 B, value: 4, compressed_value: 8)
├── 36 B ManagerMultisigRound (1 keys, key: 32 B, compressed_key: 39 B, value: 4, compressed_value: 8)
├── 36 B CounterForRcAccounts (1 keys, key: 32 B, compressed_key: 39 B, value: 4, compressed_value: 8)
├── 36 B CounterForPendingXcmMessages (1 keys, key: 32 B, compressed_key: 39 B, value: 4, compressed_value: 6)
├── 34 B Unknown (1 keys, key: 32 B, compressed_key: 39 B, value: 2, compressed_value: 6)
└── 33 B RcMigrationStage (1 keys, key: 32 B, compressed_key: 39 B, value: 1, compressed_value: 5)

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review November 25, 2025 17:07
/// Unreleased migrations. Add new ones here:
pub type Unreleased = ();
pub type Unreleased = (
frame_support::migrations::RemovePallet<
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many storage items are these?

Copy link
Copy Markdown
Member Author

@ggwpez ggwpez Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking on PAH and KAH is similar. Very small footprint:

139 B AhMigrator
├ 36 B MigrationStartBlock
├ 36 B MigrationEndBlock
├ 34 B Unknown
└ 33 B AhMigrationStage

Comment thread system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs Outdated
Comment thread system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs Outdated
Comment thread system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs Outdated
Comment thread system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs Outdated
Comment thread system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs Outdated
Comment thread system-parachains/asset-hubs/asset-hub-kusama/src/ah_migration/call_filter.rs Outdated
Comment thread relay/polkadot/src/xcm_config.rs Outdated
Comment thread relay/kusama/src/xcm_config.rs Outdated
ggwpez and others added 11 commits November 27, 2025 16:08
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez added 4 commits March 30, 2026 12:09
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Comment thread relay/kusama/src/lib.rs
Crowdloan(..) => false,

// Coretime: request_revenue_at is allowed, rest handled by catch-all.
Coretime(coretime::Call::<Runtime>::request_revenue_at { .. }) => true,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, why separate arm for this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make it easier to see. No good reason.

ggwpez added 9 commits April 1, 2026 11:25
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Copy link
Copy Markdown
Contributor

@sigurpol sigurpol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (staking & friends - wise)

ggwpez added 2 commits April 1, 2026 15:28
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez moved this from Todo to In Progress in Runtime releases Apr 1, 2026
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Comment thread relay/kusama/src/xcm_config.rs Outdated
Comment thread relay/kusama/src/xcm_config.rs Outdated
Comment thread relay/polkadot/src/xcm_config.rs Outdated
Comment thread relay/polkadot/src/xcm_config.rs Outdated
ggwpez and others added 4 commits April 1, 2026 19:46
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

Review required! Latest push from author must always be reviewed

@ggwpez ggwpez enabled auto-merge (squash) April 1, 2026 19:01
@ggwpez ggwpez merged commit d5c7438 into main Apr 1, 2026
92 of 94 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Runtime releases Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants