Add back support for zero gas price validated transactions#875
Merged
sorpaas merged 1 commit intopolkadot-evm:masterfrom Oct 10, 2022
Merged
Conversation
sorpaas
approved these changes
Oct 10, 2022
24 tasks
notlesh
pushed a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Oct 10, 2022
1 task
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#857 introduced several valid changes, but introduced incompatibilites with XCM->EVM scenarios by mistake.
We want to allow zero gas price, previously validated, transactional calls to the
runnerthrough thefp_ethereum::ValidatedTransactioncode path. The reason is fees are already withdrawn prior to entering the runner somewhere else e.g. inBuyExecutionxcm instruction.