Skip to content

Fix geth error messages#870

Merged
sorpaas merged 3 commits intopolkadot-evm:masterfrom
moonbeam-foundation:tgm-fix-geth-err-messages
Oct 4, 2022
Merged

Fix geth error messages#870
sorpaas merged 3 commits intopolkadot-evm:masterfrom
moonbeam-foundation:tgm-fix-geth-err-messages

Conversation

@tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Oct 4, 2022

This PR:

  • Brings changes in the formatted errors according to what is expected in geth.
  • Removes InvalidGasLimit and adds GasLimitTooLow, GasLimitTooHigh variants to TransactionValidationError enum.
  • TransactionValidationError is moved to fp_ethereum.
  • Uses TransactionValidationError in the formatter instead InvalidEvmTransactionError which was incorrect.

@tgmichel tgmichel marked this pull request as ready for review October 4, 2022 13:52
@tgmichel tgmichel requested a review from sorpaas as a code owner October 4, 2022 13:52
@sorpaas sorpaas merged commit d2516b3 into polkadot-evm:master Oct 4, 2022
notlesh pushed a commit to moonbeam-foundation/frontier that referenced this pull request Oct 4, 2022
* Fix geth error messages

* taplo
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
* Fix geth error messages

* taplo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants