Handle earliest tag for BlockNumber#836
Merged
sorpaas merged 4 commits intopolkadot-evm:masterfrom Sep 8, 2022
Merged
Conversation
sorpaas
approved these changes
Aug 31, 2022
Member
|
LGTM, but please fix the code style issue complained by the CI. |
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* Handle `earliest` tag for `BlockNumber` * Add ts-test * editorconfig * prettier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eth_getLogsandeth_getFilterLogsrpc requests using theearliesttag currently fallback to the best block, which usually returns a misleading empty result. This PR changes that, and handlesearliestas the genesis block.