Fix panic in pending_runtime_api with Aura consensus env#814
Merged
sorpaas merged 4 commits intopolkadot-evm:masterfrom Aug 15, 2022
Merged
Fix panic in pending_runtime_api with Aura consensus env#814sorpaas merged 4 commits intopolkadot-evm:masterfrom
sorpaas merged 4 commits intopolkadot-evm:masterfrom
Conversation
sorpaas
reviewed
Aug 15, 2022
| @@ -482,7 +482,8 @@ where | |||
| .collect::<Vec<<B as BlockT>::Extrinsic>>(); | |||
| // Manually initialize the overlay. | |||
| let header = client.header(best).unwrap().unwrap(); | |||
Member
There was a problem hiding this comment.
We need to remove all those unwraps.
sorpaas
approved these changes
Aug 15, 2022
tgmichel
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Sep 12, 2022
tgmichel
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Sep 22, 2022
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
…m#814) * Fix pending_runtime_api * Use sp_api::HeaderT * Fix lint * Fix lint Co-authored-by: icodezjb <icodezjb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same slot is used twice at https://github.com/paritytech/substrate/blob/master/frame/aura/src/lib.rs#L93
api.initialize_block(&parent_hash, &best_header)instead ofapi.initialize_block(&best_hash, &best_header)It solves the panic of 2, reason refer to 1