Skip to content

Add AsRef and AsMut for AccountId20#1139

Merged
sorpaas merged 2 commits intopolkadot-evm:masterfrom
darwinia-network:bear-account-asref
Aug 1, 2023
Merged

Add AsRef and AsMut for AccountId20#1139
sorpaas merged 2 commits intopolkadot-evm:masterfrom
darwinia-network:bear-account-asref

Conversation

@boundless-forest
Copy link
Copy Markdown
Collaborator

@sorpaas sorpaas merged commit 22aaafe into polkadot-evm:master Aug 1, 2023
@boundless-forest boundless-forest deleted the bear-account-asref branch August 1, 2023 13:17
Comment thread rust-toolchain.toml
components = ["rustfmt", "clippy"]
targets = ["wasm32-unknown-unknown"]
profile = "minimal"
channel = "nightly-2023-05-22"
Copy link
Copy Markdown
Collaborator

@koushiro koushiro Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boundless-forest why change the rust-toolchain config in this PR?

Copy link
Copy Markdown
Collaborator

@koushiro koushiro Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the same rust toolchain config of polkadot releases (https://github.com/paritytech/polkadot/releases/tag/v1.0.0)

channel="nightly-2023-05-22" is not 8b4b20836

rustup show

nightly-2023-05-23-aarch64-apple-darwin
rustc 1.71.0-nightly (8b4b20836 2023-05-22)

Copy link
Copy Markdown
Collaborator Author

@boundless-forest boundless-forest Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nightly-2023-05-22 is not 8b4b20836

Why? rustc 1.71.0-nightly (8b4b20836 2023-05-22) I understand the 8b4b20836 is the nightly version id of the 2023-05-22.

Is this output misleading?

Copy link
Copy Markdown
Collaborator

@koushiro koushiro Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could try to run the command rustup show in the frontier workspace and you didn't change the toolchain of CI at the same time.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I see your point. How about updating this later in next PR?

boundless-forest added a commit to boundless-forest/frontier that referenced this pull request Aug 3, 2023
* Update toolchain toml config

* Add helper functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants